Test collection linearizer service #2153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenHenning: PTAL. |
Current coverage is 48.01% (diff: 100%)@@ develop #2153 diff @@
==========================================
Files 190 190
Lines 15969 15969
Methods 2747 2747
Messages 0 0
Branches 2707 2707
==========================================
Hits 7667 7667
Misses 8302 8302
Partials 0 0
|
* Started redesign of donation page. Created right-hand donation option box. * Created new donation page. Left side has donation information and a space for a video. The right side has donation options. On narrow screens, the left side is not displayed. * Made some style corrections. * Responded to PR comments. * Addressed PR comment in base.html.
Hide the 'Activities' tab in the production environment.
…ditor (#2283) * Add ability to edit language code and tags in collection editor * Add tag checking and variable renaming * Correct assets linting errors * Move collection tag validation and revert asset linting changes * Move tag validation to validation service * Fix backend collection tests * Tweak collection tag validation * Fix validation locations
…in order to make the flow of ideas smoother. (#2313) * Update alternate text for the first part of the description of Oppia in order to make the flow of ideas smoother. * Fix error in pt translation.
* Added prerender to the splash page * Disabled prerender for performance tests
|
Hi @BenHenning, is this mergeable? |
* Update wording on Teach page; fix CSS on Teach and About pages. * Add fallback for CSS calc rule.
| [firstCollectionNode, secondCollectionNode, thirdCollectionNode]); | ||
| }); | ||
|
|
||
| iit('should correctly shift the last node', function() { |
There was a problem hiding this comment.
I think you forgot to revert this back to it() ;)
|
Thanks @amgowano! This LGTM, except I think you forgot to revert the |
…tory and remove unnecessary build task. (#2294) * Moved invocation of process_third_party_libs method * Modified build.py and gulpfile.js, and calls to gulp.js. Moved opening the browser window after the build.py script. * Modified gulpfile.js. * Modified method name * Updated comment * Added comment to clarify the build process
|
Thanks for the review @BenHenning |
…linearizer-service
|
@BenHenning -- do you know why this isn't merged yet? |
|
(Apart from the merge conflicts, that is...) |
This was referenced Aug 19, 2016
|
Superseded by #2406. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1998: implement tests for collection linearizer service.