Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19110: Implement job to copy mis-placed translation images #21378

Closed
wants to merge 10 commits into from
+1,162 −8
Closed

Fix #19110: Implement job to copy mis-placed translation images #21378

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
522b872
Implement job to copy mis-placed translation images
U8NWXD Dec 4, 2024
80c94f9
Implement job to copy mis-placed translation images
U8NWXD Dec 9, 2024
2c9314e
Fix type annotations in JobRunResult
U8NWXD Dec 9, 2024
02c636b
Add tests
U8NWXD Dec 9, 2024
0219c12
Merge branch 'fix-19110' of github.com:U8NWXD/oppia into fix-19110
U8NWXD Dec 9, 2024
fd26f37
Fix tests
U8NWXD Dec 9, 2024
c5c8922
Fix job imports test
U8NWXD Dec 9, 2024
f929aa1
Separate debugging and audit jobs
U8NWXD Dec 10, 2024
7d4ef07
Clean up validation logic
U8NWXD Dec 10, 2024
ae64c53
Merge branch 'develop' into fix-19110
seanlip Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up validation logic
  • Loading branch information
@U8NWXD
U8NWXD committed Dec 10, 2024
commit 7d4ef07a21898274d7066e1c3d7fd2561e6c3ffd
15 changes: 3 additions & 12 deletions core/jobs/batch_jobs/missing_translation_images_repair_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,20 +265,11 @@ def _filter_copy_ops(
Returns:
bool. True if and only if the source file exists and the destination
file does not exist.

Raises:
Exception. Raised if the dictionary is malformed, specifically if
the values of either src_exist or dst_exist do not have length
1.
"""
_, copy_info = group
if (
len(copy_info['src_exist']) != 1
or len(copy_info['dst_exist']) != 1
):
raise Exception(
'Unexpected copy info dict structure: %s' % copy_info)
return copy_info['src_exist'][0] and not copy_info['dst_exist'][0]
src_exist, = copy_info['src_exist']
dst_exist, = copy_info['dst_exist']
return src_exist and not dst_exist


class CopyMissingTranslationImagesJob(base_jobs.JobBase):
Expand Down
Loading