Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19110: Implement job to copy mis-placed translation images #21378

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
+1,178 −9
Open

Fix #19110: Implement job to copy mis-placed translation images #21378

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
522b872
Implement job to copy mis-placed translation images
U8NWXD Dec 4, 2024
80c94f9
Implement job to copy mis-placed translation images
U8NWXD Dec 9, 2024
2c9314e
Fix type annotations in JobRunResult
U8NWXD Dec 9, 2024
02c636b
Add tests
U8NWXD Dec 9, 2024
0219c12
Merge branch 'fix-19110' of github.com:U8NWXD/oppia into fix-19110
U8NWXD Dec 9, 2024
fd26f37
Fix tests
U8NWXD Dec 9, 2024
c5c8922
Fix job imports test
U8NWXD Dec 9, 2024
f929aa1
Separate debugging and audit jobs
U8NWXD Dec 10, 2024
7d4ef07
Clean up validation logic
U8NWXD Dec 10, 2024
ae64c53
Merge branch 'develop' into fix-19110
seanlip Dec 12, 2024
24ee61b
Add logging
U8NWXD Jan 20, 2025
f4f433e
Merge branch 'fix-19110' of github.com:U8NWXD/oppia into fix-19110
U8NWXD Jan 20, 2025
d203733
Merge branch 'develop' of github.com:oppia/oppia into fix-19110
U8NWXD Jan 20, 2025
c3612ae
Document exception
U8NWXD Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix type annotations in JobRunResult 
The as_stdout() and as_stderr() functions were annotated as only
accepting str and int arguments, but they are designed (and frequently
used) to process arbitrary input types. Therefore, they should actually
accept inputs of type Any.
  • Loading branch information
@U8NWXD
U8NWXD committed Dec 9, 2024
commit 2c9314efa311dcd7822ce8c3c625cba1e6d78049
8 changes: 6 additions & 2 deletions core/jobs/types/job_run_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ def __init__(self, stdout: str = '', stderr: str = ''):

@classmethod
def as_stdout(
cls, value: Union[str, int], use_repr: bool = False
# NOTE: Here we use type Any because this function can operate on inputs
# of any type.
cls, value: Any, use_repr: bool = False
) -> JobRunResult:
"""Returns a new JobRunResult with a stdout value.

Expand All @@ -83,7 +85,9 @@ def as_stdout(

@classmethod
def as_stderr(
cls, value: Union[str, int], use_repr: bool = False
# NOTE: Here we use type Any because this function can operate on inputs
# of any type.
cls, value: Any, use_repr: bool = False
) -> JobRunResult:
"""Returns a new JobRunResult with a stderr value.

Expand Down