Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #21294 : Drop inactive contributors from issues that they aren't working on. #21377

Closed
wants to merge 7 commits into from
Closed

Fix #21294 : Drop inactive contributors from issues that they aren't working on. #21377

wants to merge 7 commits into from

Conversation

Ashu463
Copy link

@Ashu463 Ashu463 commented Dec 4, 2024 •
edited
Loading

Overview

  1. This PR fixes or fixes [Feature Request]: Drop inactive contributors from issues that they aren't working on. #21294 .
  2. This PR does the following: Unassigned those contributors who are responsible to solve any issue but inactive for past 7days, dropping a suitable message for their inactivity. Moreover it will skips those assignee who are collaborator.

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

I am giving video as proofs along with URLs if any issue occur then you may visit through those.

  • Video which shows when assignee is collaborator and doesn't have any activity i.e. there is neither any PR or any comment, link
Screencast.from.2024-11-29.20-05-17.mp4
  • Video when assignee isn't a collaborator but opened a PR, link
without-collaborator.mp4
  • Video when assignee is neither a collaborator nor he opened any PR. link
Screencast.from.2024-11-23.17-53-27.mp4

Detailed Description

So in this section I had discussed the approach of solution that I used to solve the issue, here is how I did it:

  • First of all I had make a CI workflow which runs at every midnight.
  • This workflow runs a python script which handles all cases related to issue.

Various cases related to issue :

  • Case - 1: Assignee is a collaborator but didn't opened any PR.
  • Case - 2: Assignee is a collaborator but opened PR.
  • Case - 3: Assignee isn't a collaborator but have some activity.
  • Case - 4: Assignee isn't a collaborator and hadn't any activity like opened PR or some comments within 7 days.

You can look into scripts/inactive_issue_checker.py to check how these cases are handled.

PR Pointers

@Ashu463 Ashu463 requested a review from a team as a code owner December 4, 2024 17:36
@Ashu463 Ashu463 requested a review from U8NWXD December 4, 2024 17:36
@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 4, 2024

Assigning @U8NWXD for the first pass review of this PR. Thanks!

@oppiabot oppiabot bot assigned U8NWXD Dec 4, 2024
@Ashu463
Copy link
Author

Ashu463 commented Dec 4, 2024

I also wanna add there were some CI checks are failing i.e. Mypy types checks, Backend associated test, and Lint checks, so will need help to figure them out.

@U8NWXD
Copy link
Member

U8NWXD commented Dec 11, 2024 •
edited
Loading

@Ashu463 sorry for my delay in reviewing your PR. For instructions on how to resolve the CI failures, see our wiki: https://github.com/oppia/oppia/wiki/If-CI-checks-fail-on-your-PR. They look like issues with your changes that you'll need to fix, except for the backend test coverage check, which looks to be a random setup failure. That job will rerun when you push commits to fix the other CI failures, so I don't think there's anything you need to do for it.

Also, regarding the "I have written tests for my code." checkbox in the PR description, you do need to write tests for your changes. That's why the backend associated test file check is failing.

Since you'll need to make code changes to resolve the CI failures, I'm holding off on reviewing until those changes are made.

@U8NWXD U8NWXD assigned Ashu463 and unassigned U8NWXD Dec 11, 2024
@Ashu463
Copy link
Author

Ashu463 commented Dec 12, 2024

Hey @U8NWXD thanks for reviewing, will write test case for newly created function. Else I don't think to do else if yes then pls let me know.
Thanks

@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 19, 2024

Hi @Ashu463, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Dec 19, 2024
@Ashu463
Copy link
Author

Ashu463 commented Dec 22, 2024

Hey @U8NWXD so sorry for the delay but I was busy in end sem exams, will submit the work very soon.
Thanks !

@oppiabot oppiabot bot removed the stale label Dec 22, 2024
@Ashu463
Copy link
Author

Ashu463 commented Dec 22, 2024

@U8NWXD could you PTAL, also I had added this test file and inactive issue checker script inside /scripts folder but all test cases for front and back end code is written inside /core so should I change it or it will all fine ?

@oppiabot oppiabot bot assigned U8NWXD and unassigned Ashu463 Dec 22, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 22, 2024

Unassigning @Ashu463 since a re-review was requested. @Ashu463, please make sure you have addressed all review comments. Thanks!

@Ashu463
Copy link
Author

Ashu463 commented Dec 27, 2024

Hey @U8NWXD pls merge if everything seems to be fine, if not then pls let me know.
Thanks !

@Ashu463 Ashu463 requested a review from a team as a code owner December 29, 2024 04:26
@seanlip
Copy link
Member

seanlip commented Dec 29, 2024 •
edited
Loading

@Ashu463 We don't permit force pushes. See our PR guidelines.

I am closing this PR, feel free to make a new one if needed. We recommend that you follow the PR guidelines carefully when making PRs. Thanks.

@seanlip seanlip closed this Dec 29, 2024
@Ashu463
Copy link
Author

Ashu463 commented Dec 29, 2024

Hey @seanlip I'm sorry but I'm unaware about this force pushing, I was just fixing those lint checks to get this PR merged.

@seanlip
Copy link
Member

seanlip commented Dec 29, 2024

That's fine, but please read the instructions carefully next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@U8NWXD U8NWXD Awaiting requested review from U8NWXD U8NWXD is a code owner automatically assigned from oppia/dev-workflow-reviewers

Assignees

@U8NWXD U8NWXD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Drop inactive contributors from issues that they aren't working on.
3 participants
@Ashu463 @U8NWXD @seanlip