oppia · Nik-09 · Apr 19, 2024 · Apr 22, 2024 · Jun 8, 2024 · Jun 9, 2024
@@ -155,7 +155,7 @@
     'category': 'Algorithms',
     'author_notes': '',
     'blurb': '',
-    'states_schema_version': 55,
+    'states_schema_version': 57,
     'init_state_name': 'Introduction',
     'language_code': 'en',
     'objective': 'Learn the exploration',
@@ -191,11 +191,6 @@
             },
             'classifier_model_id': None,
             'linked_skill_id': None,
-            'recorded_voiceovers': {
-                    'voiceovers_mapping': {
-                    'content_0': {}
-                }
-            },
             'solicit_answer_details': False,
             'card_is_checkpoint': True,
             'inapplicable_skill_misconception_ids': []

@@ -448,8 +448,7 @@ def post(self) -> None:
         new_exploration_id = exp_fetchers.get_new_exploration_id()
         if constants.ALLOW_YAML_FILE_UPLOAD:
             exp_services.save_new_exploration_from_yaml_and_assets(
-                self.user_id, yaml_content, new_exploration_id, [],
-                strip_voiceovers=True)
+                self.user_id, yaml_content, new_exploration_id, [])
             self.render_json({
                 EXPLORATION_ID_KEY: new_exploration_id
             })

@@ -383,13 +383,6 @@ def test_valid_object_raises_no_exception(self) -> None:
                 'hints': []
             },
             'linked_skill_id': None,
-            'recorded_voiceovers': {
-                'voiceovers_mapping': {
-                    'content_0': {},
-                    'default_outcome_1': {},
-                    'ca_placeholder_2': {}
-                }
-            },
             'classifier_model_id': None,
             'card_is_checkpoint': False,
             'solicit_answer_details': False,
@@ -486,16 +479,6 @@ def test_valid_object_raises_no_exception(self) -> None:
                 'solution': None
             },
             'param_changes': [],
-            'recorded_voiceovers': {
-                'voiceovers_mapping': {
-                    'content_0': {},
-                    'default_outcome_1': {},
-                    'ca_choices_2': {},
-                    'ca_choices_3': {},
-                    'feedback_4': {},
-                    'feedback_5': {}
-                }
-            },
             'solicit_answer_details': False,
             'card_is_checkpoint': False,
             'inapplicable_skill_misconception_ids': []

@@ -2373,14 +2373,6 @@ def test_accept_question_suggestion_with_image_region_interactions(
                 'id': 'ImageClickInput', 'solution': None
             },
             'param_changes': [],
-            'recorded_voiceovers': {
-                'voiceovers_mapping': {
-                    'content_0': {},
-                    'default_outcome_1': {},
-                    'feedback_2': {},
-                    'hint_3': {}
-                }
-            },
             'solicit_answer_details': False,
             'card_is_checkpoint': False,
             'inapplicable_skill_misconception_ids': []

@@ -112,114 +112,6 @@ def put(self) -> None:
         self.render_json(self.values)
 
 
-class PutVoiceArtistMetadataHandlerNormalizedPayloadDict(TypedDict):
-    """Dict representation of VoiceArtistMetadataHandler's normalized_payload
-    dictionary.
-    """
-
-    voice_artist_id: str
-    language_code: str
-    language_accent_code: str
-
-
-class VoiceArtistMetadataHandler(
-    base.BaseHandler[
-        PutVoiceArtistMetadataHandlerNormalizedPayloadDict,
-        Dict[str, str]
-    ]
-):
-    """Handler class to manage voice artist data for the voiceover admin page.
-    """
-
-    GET_HANDLER_ERROR_RETURN_TYPE = feconf.HANDLER_TYPE_JSON
-    URL_PATH_ARGS_SCHEMAS: Dict[str, str] = {}
-    HANDLER_ARGS_SCHEMAS = {
-        'GET': {},
-        'PUT': {
-            'voice_artist_id': {
-                'schema': {
-                    'type': 'basestring'
-                }
-            },
-            'language_code': {
-                'schema': {
-                    'type': 'basestring'
-                }
-            },
-            'language_accent_code': {
-                'schema': {
-                    'type': 'basestring'
-                }
-            }
-        }
-    }
-
-    @acl_decorators.can_access_voiceover_admin_page
-    def get(self) -> None:
-        """Retrieves voice artist data for the voiceover admin page."""
-        voice_artist_id_to_language_mapping = (
-            voiceover_services.get_all_voice_artist_language_accent_mapping())
-        voice_artist_id_to_voice_artist_name = (
-            voiceover_services.get_voice_artist_ids_to_voice_artist_names())
-
-        self.values.update({
-            'voice_artist_id_to_language_mapping':
-                voice_artist_id_to_language_mapping,
-            'voice_artist_id_to_voice_artist_name':
-                voice_artist_id_to_voice_artist_name
-        })
-        self.render_json(self.values)
-
-    @acl_decorators.can_access_voiceover_admin_page
-    def put(self) -> None:
-        """Updates voice artist data from the voiceover admin page."""
-        assert self.normalized_payload is not None
-        voice_artist_id = self.normalized_payload['voice_artist_id']
-        language_code = self.normalized_payload['language_code']
-        language_accent_code = self.normalized_payload['language_accent_code']
-
-        voiceover_services.update_voice_artist_language_mapping(
-            voice_artist_id, language_code, language_accent_code)
-        self.render_json(self.values)
-
-
-class GetSampleVoiceoversForGivenVoiceArtistHandler(
-    base.BaseHandler[Dict[str, str], Dict[str, str]]
-):
-    """Handler class to get sample contributed voiceovers of a voice artist in
-    a given language.
-    """
-
-    GET_HANDLER_ERROR_RETURN_TYPE = feconf.HANDLER_TYPE_JSON
-    URL_PATH_ARGS_SCHEMAS = {
-        'voice_artist_id': {
-            'schema': {
-                'type': 'basestring'
-            }
-        },
-        'language_code': {
-            'schema': {
-                'type': 'basestring'
-            }
-        }
-    }
-    HANDLER_ARGS_SCHEMAS: Dict[str, Dict[str, str]] = {'GET': {}}
-
-    @acl_decorators.can_access_voiceover_admin_page
-    def get(self, voice_artist_id: str, language_code: str) -> None:
-        exploration_id_to_filenames = (
-            voiceover_services.get_voiceover_filenames(
-                voice_artist_id=voice_artist_id,
-                language_code=language_code
-            )
-        )
-
-        self.values.update({
-            'exploration_id_to_filenames': exploration_id_to_filenames,
-        })
-        self.render_json(self.values)
-
-
 class EntityVoiceoversBulkHandler(
     base.BaseHandler[Dict[str, str], Dict[str, str]]
 ):

@@ -18,7 +18,6 @@
 
 from core import feconf
 from core.domain import state_domain
-from core.domain import user_services
 from core.domain import voiceover_domain
 from core.domain import voiceover_services
 from core.tests import test_utils
@@ -116,185 +115,6 @@ def test_invalid_language_accent_codes_mapping_raise_error(self) -> None:
         self.logout()
 
 
-class VoiceArtistMetadataHandlerTests(test_utils.GenericTestBase):
-    """The class validates functionality related to voice artist metadata model.
-    """
-
-    def setUp(self) -> None:
-        super().setUp()
-        self.signup(self.VOICEOVER_ADMIN_EMAIL, self.VOICEOVER_ADMIN_USERNAME)
-        self.set_voiceover_admin([self.VOICEOVER_ADMIN_USERNAME])
-        auth_id = 'someUser'
-        self.voice_artist_username = 'username'
-        user_settings = user_services.create_new_user(
-            auth_id, 'user@example.com')
-        self.voice_artist_id = user_settings.user_id
-        user_services.set_username(
-            self.voice_artist_id, self.voice_artist_username)
-
-        self.voiceover1: state_domain.VoiceoverDict = {
-            'filename': 'filename1.mp3',
-            'file_size_bytes': 3000,
-            'needs_update': False,
-            'duration_secs': 6.1
-        }
-        self.voiceover2: state_domain.VoiceoverDict = {
-            'filename': 'filename2.mp3',
-            'file_size_bytes': 3500,
-            'needs_update': False,
-            'duration_secs': 5.9
-        }
-        self.voiceover3: state_domain.VoiceoverDict = {
-            'filename': 'filename3.mp3',
-            'file_size_bytes': 3500,
-            'needs_update': False,
-            'duration_secs': 5.0
-        }
-
-        self.language_code_to_accent: Dict[str, str] = {
-            'en': 'en-US',
-            'hi': 'hi-IN'
-        }
-
-        self.content_id_to_voiceovers_mapping: (
-            voiceover_domain.ContentIdToVoiceoverMappingType) = {
-                'content_1': {
-                    'en': (self.voice_artist_id, self.voiceover1)
-                },
-                'content_2': {
-                    'hi': (self.voice_artist_id, self.voiceover2)
-                },
-                'content_3': {
-                    'ar': (self.voice_artist_id, self.voiceover1)
-                }
-            }
-
-        exploration_voice_artist_link_model = (
-            voiceover_services.
-            create_exploration_voice_artists_link_model_instance(
-                exploration_id='exploration_id',
-                content_id_to_voiceovers_mapping=(
-                    self.content_id_to_voiceovers_mapping)
-            )
-        )
-        exploration_voice_artist_link_model.put()
-
-        voiceover_services.update_voice_artist_metadata(
-            voice_artist_id=self.voice_artist_id,
-            language_code_to_accent=(
-                self.language_code_to_accent)
-        )
-
-    def test_get_voice_artist_data_for_voiceover_admin_page(self) -> None:
-        self.login(self.VOICEOVER_ADMIN_EMAIL, is_super_admin=True)
-
-        expected_voice_artist_id_to_language_mapping = {
-            self.voice_artist_id: {
-                'en': 'en-US',
-                'hi': 'hi-IN',
-                'ar': ''
-            }
-        }
-        expected_voice_artist_id_to_voice_artist_name = {
-            self.voice_artist_id: self.voice_artist_username
-        }
-        json_response = self.get_json(feconf.VOICE_ARTIST_METADATA_HANDLER)
-
-        self.assertDictEqual(
-            json_response['voice_artist_id_to_language_mapping'],
-            expected_voice_artist_id_to_language_mapping
-        )
-        self.assertDictEqual(
-            json_response['voice_artist_id_to_voice_artist_name'],
-            expected_voice_artist_id_to_voice_artist_name
-        )
-        self.logout()
-
-    def test_should_update_voice_artist_language_mapping(self) -> None:
-        self.login(self.VOICEOVER_ADMIN_EMAIL, is_super_admin=True)
-        csrf_token = self.get_new_csrf_token()
-
-        initial_voice_artist_id_to_language_mapping = {
-            self.voice_artist_id: {
-                'en': 'en-US',
-                'hi': 'hi-IN',
-                'ar': ''
-            }
-        }
-        voice_artist_id_to_language_mapping = (
-            voiceover_services.get_all_voice_artist_language_accent_mapping())
-
-        self.assertDictEqual(
-            voice_artist_id_to_language_mapping,
-            initial_voice_artist_id_to_language_mapping
-        )
-
-        payload = {
-            'voice_artist_id': self.voice_artist_id,
-            'language_code': 'ar',
-            'language_accent_code': 'ar-EG'
-        }
-        self.put_json(
-            feconf.VOICE_ARTIST_METADATA_HANDLER,
-            payload, csrf_token=csrf_token)
-
-        final_voice_artist_id_to_language_mapping = {
-            self.voice_artist_id: {
-                'en': 'en-US',
-                'hi': 'hi-IN',
-                'ar': 'ar-EG'
-            }
-        }
-        voice_artist_id_to_language_mapping = (
-            voiceover_services.get_all_voice_artist_language_accent_mapping())
-
-        self.assertDictEqual(
-            voice_artist_id_to_language_mapping,
-            final_voice_artist_id_to_language_mapping
-        )
-        self.logout()
-
-    def test_get_exp_id_to_filenames_for_given_voice_artist(self) -> None:
-        self.login(self.VOICEOVER_ADMIN_EMAIL, is_super_admin=True)
-
-        handler_url = (
-            '%s/%s/%s' % (
-                feconf.GET_SAMPLE_VOICEOVERS_FOR_VOICE_ARTIST,
-                self.voice_artist_id,
-                'en')
-        )
-
-        expected_exp_id_to_filenames = {
-            'exploration_id': ['filename1.mp3']
-        }
-
-        json_response = self.get_json(handler_url)
-
-        self.assertDictEqual(
-            json_response['exploration_id_to_filenames'],
-            expected_exp_id_to_filenames
-        )
-
-        handler_url = (
-            '%s/%s/%s' % (
-                feconf.GET_SAMPLE_VOICEOVERS_FOR_VOICE_ARTIST,
-                self.voice_artist_id,
-                'hi')
-        )
-
-        expected_exp_id_to_filenames = {
-            'exploration_id': ['filename2.mp3']
-        }
-
-        json_response = self.get_json(handler_url)
-
-        self.assertDictEqual(
-            json_response['exploration_id_to_filenames'],
-            expected_exp_id_to_filenames
-        )
-        self.logout()
-
-
 class EntityVoiceoversBulkHandlerTests(test_utils.GenericTestBase):
     """Test class to validate entity voiceovers bulk handler."""