Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove voiceover from exp schema #20675

Draft
wants to merge 39 commits into
base: develop
Choose a base branch
from
Draft

Remove voiceover from exp schema #20675

wants to merge 39 commits into from

Conversation

Nik-09
Copy link
Member

@Nik-09 Nik-09 commented Jul 15, 2024 •
edited
Loading

Overview

The PR removes the recorded_voiceovers field from the State schema of Exploration and Question.

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Testing doc (for PRs with Beam jobs that modify production server data)

  • A testing doc has been written: ... (ADD LINK) ...
  • (To be confirmed by the server admin) All jobs in this PR have been verified on a live server, and the PR is safe to merge.

Proof that changes are correct

Description: The video demonstrates that the earlier exploration schema (version 55) contains the “recorded_voiceovers” field inside the State and after the exploration migration, this field is removed from the exploration schema (version 56).

exploration_migration_video.mp4

Description: This video shows that in the latest exploration schema version, editing, saving, and publishing are completed successfully.

exploration_editing.mp4

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

@oppiabot OppiaBot
Copy link

oppiabot bot commented Jul 15, 2024

Hi @Nik-09, can you complete the following:

  1. The body of this PR is missing the required description, please update the body with a description of what this PR does.
    Thanks!

@oppiabot OppiaBot
Copy link

oppiabot bot commented Jul 15, 2024

Hi @Nik-09 please assign the required reviewer(s) for this PR. Thanks!

@oppiabot OppiaBot
Copy link

oppiabot bot commented Jul 21, 2024

Hi @Nik-09. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

1 similar comment
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jul 21, 2024

Hi @Nik-09. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot OppiaBot
Copy link

oppiabot bot commented Jul 28, 2024

Hi @Nik-09, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Jul 28, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Nov 18, 2024

Hi @Nik-09, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Nov 18, 2024
@oppiabot oppiabot bot closed this Nov 22, 2024
@Nik-09 Nik-09 reopened this Nov 24, 2024
@oppiabot oppiabot bot removed the stale label Nov 24, 2024
@Nik-09 Nik-09 mentioned this pull request Nov 27, 2024
Merged
7 tasks
@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 1, 2024

Hi @Nik-09, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Dec 1, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 4, 2024

Hi @Nik-09. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 19, 2024

Hi @Nik-09, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Dec 19, 2024
@oppiabot oppiabot bot closed this Dec 23, 2024
@Nik-09 Nik-09 reopened this Dec 27, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 27, 2024

Hi @Nik-09. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@Nik-09 Nik-09 marked this pull request as draft December 30, 2024 10:13
@oppiabot OppiaBot
Copy link

oppiabot bot commented Jan 6, 2025

Hi @Nik-09, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenYu2018 StephenYu2018 StephenYu2018 approved these changes

@kevintab95 kevintab95 Awaiting requested review from kevintab95 kevintab95 is a code owner automatically assigned from oppia/core-reviewers

@BenHenning BenHenning Awaiting requested review from BenHenning BenHenning is a code owner automatically assigned from oppia/web-android-compatibility-reviewers

@U8NWXD U8NWXD Awaiting requested review from U8NWXD U8NWXD is a code owner automatically assigned from oppia/dev-workflow-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@Nik-09 Nik-09

Labels
PR: Affects datastore layer Labels to indicate a PR that changes the datastore layer. PR: don't merge - HAS MERGE CONFLICTS stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Nik-09 @StephenYu2018 @vojtechjelinek @kevintab95 @BenHenning @DubeySandeep @U8NWXD @seanlip