Fix yaml generation #16921

vojtechjelinek · 2023-01-13T02:39:12Z

Overview

This PR fixes #N/A
This PR does the following: Fixes the script that adds new indexes into index.yaml when the dev server is run.

The problem was that the devserver does not update index.yaml (at least on my device) in cache folder it only updates datastore-indexes-auto.xml which seems to be just an XML representation of the index.yaml, so this PR uses the datastore-indexes-auto.xml instead of index.yaml

Essential Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The linter/Karma presubmit checks have passed locally on your machine.
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
- This lets reviewers restart your CircleCI tests for you.
The PR is made from a branch that's not called "develop".

Proof that changes are correct

I've tested this locally with #16534 and all indexes were correctly added.

PR Pointers

Make sure to follow the instructions for making a code change.
If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
For what code owners will expect, see the Code Owner's wiki page.
Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
Never force push. If you do, your PR will be closed.
Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

oppiabot · 2023-01-13T02:39:13Z

Hi @vojtechjelinek, can you complete the following:

The body of this PR is missing the required description, please update the body with a description of what this PR does.
The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing.
Thanks!

oppiabot · 2023-01-13T02:39:24Z

Hi, @vojtechjelinek, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @vojtechjelinek to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

gp201

LGTM

seanlip

@vojtechjelinek Could you please describe the problem a bit more in the description?

Also should we have a test that ensures the xml is converted into yaml correctly?

Thanks!

seanlip · 2023-01-16T11:23:16Z

Also, just to be clear -- could you also please explain what the developer experience will be like (for indexes) after this PR is merged? Will they need to do anything to generate the indexes in index.yaml, or will that "just happen"?

Should we perhaps send a note to the devs about this?

vojtechjelinek · 2023-01-16T12:20:44Z

@seanlip Done. Added more tests.

I've explained the changes in the description.

For a developer this should be as before. If they perform some action that requires index in their local devserver (basically testing their newly added code) the index will be added to their index.yaml

seanlip

OK, LGTM. Thanks @vojtechjelinek !

vojtechjelinek · 2023-01-17T11:27:12Z

@seanlip Please merge this.

seanlip · 2023-01-17T11:28:16Z

Merging per @vojtechjelinek's request since there is no one besides him currently in the dependencies reviewer team.

fix interaction null type related bugs Fix oppia#16504: Android beta page fixes (oppia#16688) * Android beta page fixes * address comments * fix indentation * fix fe test * address comments * code comments * fix test * fix test * address comments * address comment and fix tests * increase z-index of button so clicks are handled correctly * fix test * fix coverage Fix oppia#16648: Increases tick time to fix debounce frontend test flake (oppia#16958) flake fix FIX#16908 : Submit button in Feedback dialogbox must have layout indicating its a button (oppia#16954) Update feedback-popup.component.html Fix yaml generation (oppia#16921) * Fix yaml generation * Fix indexes * Add tests fix null bug fix bug in constructor fix bug2 interaction id related bug 1 test interaction id bug 1 interaction id null test bug 1 add test coverage recordLearnerAnswer interaction id not null add coverage minor minor minor minor minor minor minor

* remove interactionId null type fix interaction null type related bugs Fix #16504: Android beta page fixes (#16688) * Android beta page fixes * address comments * fix indentation * fix fe test * address comments * code comments * fix test * fix test * address comments * address comment and fix tests * increase z-index of button so clicks are handled correctly * fix test * fix coverage Fix #16648: Increases tick time to fix debounce frontend test flake (#16958) flake fix FIX#16908 : Submit button in Feedback dialogbox must have layout indicating its a button (#16954) Update feedback-popup.component.html Fix yaml generation (#16921) * Fix yaml generation * Fix indexes * Add tests fix null bug fix bug in constructor fix bug2 interaction id related bug 1 test interaction id bug 1 interaction id null test bug 1 add test coverage recordLearnerAnswer interaction id not null add coverage minor minor minor minor minor minor minor * fix explorationHistoryTab test bug * keep Interaction id null type, remove Answergroup interactionId null type * check interactionObjectfactory interactionId null type minor linter check 1 * delete answergroupobjectfactory null interactionid type * minor * interactionobjectfactory createfrombackenddict interactionId only string * minor * parameter-metadata service test interaction id is not null * minor * minor * minor check * parameter-metadata.service get unset parameters info test interactionId not null * linter check * linter check * minor * exploration-warnings service test remove answergroup

…ppia#17132) * remove interactionId null type fix interaction null type related bugs Fix oppia#16504: Android beta page fixes (oppia#16688) * Android beta page fixes * address comments * fix indentation * fix fe test * address comments * code comments * fix test * fix test * address comments * address comment and fix tests * increase z-index of button so clicks are handled correctly * fix test * fix coverage Fix oppia#16648: Increases tick time to fix debounce frontend test flake (oppia#16958) flake fix FIX#16908 : Submit button in Feedback dialogbox must have layout indicating its a button (oppia#16954) Update feedback-popup.component.html Fix yaml generation (oppia#16921) * Fix yaml generation * Fix indexes * Add tests fix null bug fix bug in constructor fix bug2 interaction id related bug 1 test interaction id bug 1 interaction id null test bug 1 add test coverage recordLearnerAnswer interaction id not null add coverage minor minor minor minor minor minor minor * fix explorationHistoryTab test bug * keep Interaction id null type, remove Answergroup interactionId null type * check interactionObjectfactory interactionId null type minor linter check 1 * delete answergroupobjectfactory null interactionid type * minor * interactionobjectfactory createfrombackenddict interactionId only string * minor * parameter-metadata service test interaction id is not null * minor * minor * minor check * parameter-metadata.service get unset parameters info test interactionId not null * linter check * linter check * minor * exploration-warnings service test remove answergroup

Fix yaml generation

3d0bc6d

oppiabot bot assigned vojtechjelinek Jan 13, 2023

Fix indexes

453b136

vojtechjelinek removed their assignment Jan 14, 2023

vojtechjelinek marked this pull request as ready for review January 14, 2023 20:47

vojtechjelinek requested review from a team as code owners January 14, 2023 20:47

vojtechjelinek requested a review from gp201 January 14, 2023 20:47

vojtechjelinek assigned gp201 Jan 14, 2023

vojtechjelinek added the PR CHANGELOG: Dev Workflow -- @U8NWXD label Jan 14, 2023

gp201 approved these changes Jan 16, 2023

View reviewed changes

gp201 assigned vojtechjelinek and unassigned gp201 Jan 16, 2023

vojtechjelinek assigned seanlip and unassigned vojtechjelinek Jan 16, 2023

vojtechjelinek requested a review from seanlip January 16, 2023 10:10

seanlip requested changes Jan 16, 2023

View reviewed changes

seanlip assigned vojtechjelinek and unassigned seanlip Jan 16, 2023

Add tests

3fcf783

seanlip approved these changes Jan 16, 2023

View reviewed changes

vojtechjelinek assigned seanlip and unassigned vojtechjelinek Jan 17, 2023

seanlip merged commit a02dd00 into oppia:develop Jan 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix yaml generation #16921

Fix yaml generation #16921

vojtechjelinek commented Jan 13, 2023 •

edited

Loading

oppiabot bot commented Jan 13, 2023

oppiabot bot commented Jan 13, 2023

gp201 left a comment

seanlip left a comment

seanlip commented Jan 16, 2023

vojtechjelinek commented Jan 16, 2023

seanlip left a comment

vojtechjelinek commented Jan 17, 2023

seanlip commented Jan 17, 2023

Fix yaml generation #16921

Fix yaml generation #16921

Conversation

vojtechjelinek commented Jan 13, 2023 • edited Loading

Overview

Essential Checklist

Proof that changes are correct

PR Pointers

oppiabot bot commented Jan 13, 2023

oppiabot bot commented Jan 13, 2023

gp201 left a comment

Choose a reason for hiding this comment

seanlip left a comment

Choose a reason for hiding this comment

seanlip commented Jan 16, 2023

vojtechjelinek commented Jan 16, 2023

seanlip left a comment

Choose a reason for hiding this comment

vojtechjelinek commented Jan 17, 2023

seanlip commented Jan 17, 2023

vojtechjelinek commented Jan 13, 2023 •

edited

Loading