Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Diagnostic test session" #16615

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Revert "Diagnostic test session" #16615

merged 1 commit into from
Nov 24, 2022

Conversation

gp201
Copy link
Contributor

@gp201 gp201 commented Nov 23, 2022 •
edited
Loading

Reverts #16489

Introduced the following frontend flake into develop

Chrome Headless 107.0.5304.87 (Linux x86_64) Conversation skin component should be able to set appropriate flags for the diagnostic test FAILED
	Error: Expected true to be false.
	    at <Jasmine>
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:151889:53)
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:724084:34)
	    at ./node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (core/templates/combined-tests.spec.js:725313:30)
	Error: Expected false to be true.
	    at <Jasmine>
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:151890:69)
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:724084:34)
	    at ./node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (core/templates/combined-tests.spec.js:725313:30)
	Error: Expected true to be false.
	    at <Jasmine>
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:151891:61)
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:724084:34)
	    at ./node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (core/templates/combined-tests.spec.js:725313:30)
	Error: Expected true to be false.
	    at <Jasmine>
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:151893:14)
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:724084:34)
	    at ./node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (core/templates/combined-tests.spec.js:725313:30)
	Error: Expected true to be false.
	    at <Jasmine>
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:151894:71)
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:724084:34)
	    at ./node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (core/templates/combined-tests.spec.js:725313:30)
	Error: Expected false to be true.
	    at <Jasmine>
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:151895:53)
	    at UserContext.<anonymous> (core/templates/combined-tests.spec.js:724084:34)
	    at ./node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (core/templates/combined-tests.spec.js:725313:30)
Chrome Headless 107.0.5304.87 (Linux x86_64): Executed 5668 of 8423 (1 FAILED) (0 secs / 2 mins 4.949 secs)

diagnostic-test-player.component.ts not fully covered

GitHub action: https://github.com/oppia/oppia/actions/runs/3535515469/jobs/5933624816

@gp201 gp201 requested a review from a team as a code owner November 23, 2022 21:17
@gp201 gp201 requested review from a team November 23, 2022 21:17
@gp201 gp201 requested review from a team as code owners November 23, 2022 21:17
@oppiabot
Copy link

oppiabot bot commented Nov 23, 2022

Hi @gp201, can you complete the following:

  1. The body of this PR is missing the overview section, please update it to include the overview.
  2. The body of this PR is missing the checklist section, please update it to include the checklist.
  3. The body of this PR is missing the proof that changes are correct section, please update it to include the section.
    Thanks!

@gp201 gp201 requested a review from U8NWXD November 23, 2022 21:17
@oppiabot oppiabot bot assigned gp201 Nov 23, 2022
@gp201 gp201 requested a review from kevintab95 November 23, 2022 21:17
@oppiabot
Copy link

oppiabot bot commented Nov 23, 2022

Hi, @gp201, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @gp201 to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@gp201
Copy link
Contributor Author

gp201 commented Nov 23, 2022

@Nik-09 PTAL

@oppiabot oppiabot bot unassigned gp201 Nov 23, 2022
@oppiabot
Copy link

oppiabot bot commented Nov 23, 2022

Unassigning @gp201 since a re-review was requested. @gp201, please make sure you have addressed all review comments. Thanks!

@gp201 gp201 enabled auto-merge (squash) November 24, 2022 01:06
@gp201
Copy link
Contributor Author

gp201 commented Nov 24, 2022

@seanlip Please merge this PR.

@seanlip
Copy link
Member

seanlip commented Nov 24, 2022

Merging since this is a clean revert.

@seanlip seanlip disabled auto-merge November 24, 2022 01:31
@seanlip seanlip merged commit 9053a4c into develop Nov 24, 2022
@seanlip seanlip deleted the revert-16489-diagnostic_test_session branch November 24, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@U8NWXD U8NWXD

@kevintab95 kevintab95

Assignees

@seanlip seanlip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gp201 @seanlip