-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Contributor Recognition Infrastructure) Milestone2.4: Add certificate generation for contributors (including service method, API controller) #16513
Merged
Merged
Changes from 153 commits
Commits
Show all changes
156 commits
Select commit
Hold shift + click to select a range
c798e78
service file name changed to backend-api
chris7716 218b79c
backend api file added
chris7716 d03d579
previous service file removed from CODEOWNERS
chris7716 536a551
new backend service file added to CODEOWNERS
chris7716 b853c9a
Merge remote-tracking branch 'upstream/develop' into develop
chris7716 cab061f
Merge remote-tracking branch 'upstream/develop' into develop
chris7716 7f746b9
Merge remote-tracking branch 'upstream/develop' into develop
chris7716 63a9988
Merge branch 'oppia:develop' into develop
chris7716 40e6c29
Merge branch 'oppia:develop' into develop
chris7716 1e042a8
Merge branch 'develop' of https://github.com/oppia/oppia into develop
chris7716 6d2e59b
Merge branch 'develop' of https://github.com/oppia/oppia into develop
chris7716 ec06909
Merge branch 'develop' of https://github.com/oppia/oppia into develop
chris7716 82b8dae
Merge branch 'develop' of https://github.com/oppia/oppia into develop
chris7716 ac53598
First pass
chris7716 e211ca5
First pass
chris7716 4573973
Finalize views
chris7716 fb63259
Add stats component
chris7716 09f468a
Resolve conflicts and refactor new component
chris7716 d214681
Cover tests for stats component
chris7716 53b2d18
Improve mobile views
chris7716 2fb9fee
Remove mock responses
chris7716 d0da489
Remove unwanted spaces
chris7716 99f6370
Add question stats update
chris7716 e7b36a9
First pass
chris7716 9f920c5
Add minor changes
chris7716 d0d071b
Address comments
chris7716 f9f5aea
First pass
chris7716 9b30d40
Add new component
chris7716 b531b27
Address changes
chris7716 0b3b099
Rollback unwanted changes
chris7716 b809d10
Add initial changes
chris7716 1ce5521
Address comments
chris7716 f25c22c
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 fd17e52
AAddress comments
chris7716 71027ce
Address comments
chris7716 03f0520
Remove language from PageableStats
chris7716 464a643
Address more comments
chris7716 5185a0a
Merge branch 'milestone2.2' of https://github.com/chris7716/oppia int…
chris7716 4eb23e3
Address more comments
chris7716 4386afe
Remove unwanted changes
chris7716 0452ed7
Address more comments
chris7716 98a5b45
Fix checks
chris7716 b9988aa
Fix checks
chris7716 db831ae
Fix checks
chris7716 81d9631
Fix checks
chris7716 de42554
Fix checks
chris7716 37d34c5
Fix checks
chris7716 85ebdc4
Fix checks
chris7716 396ad54
Fix checks
chris7716 fbb9297
Fix checks
chris7716 3f6bce0
Fix checks
chris7716 dbc75cc
Fix checks
chris7716 235d239
Fix checks
chris7716 629ad5e
Fix checks
chris7716 6eca00f
Fix checks
chris7716 bc3a956
Fix checks
chris7716 cae961b
Address comments
chris7716 8f916fe
Fix checks
chris7716 d59efdc
Fix checks
chris7716 c82bd7d
Fix checks
chris7716 d42a694
Fix checks
chris7716 c91ea46
Fix checks
chris7716 a679859
Fix checks
chris7716 03b5447
Fix checks
chris7716 e17316d
Fix checks
chris7716 49c6873
Fix checks
chris7716 dfce935
Fix checks
chris7716 2536999
Fix checks
chris7716 ccb99ad
Fix checks
chris7716 990ed1d
Fix checks
chris7716 e5ded5d
Fix checks
chris7716 773fbe1
Fix checks
chris7716 cac4619
Fix checks
chris7716 d442f5c
Fix checks
chris7716 018f498
Fix checks
chris7716 f23b1bb
Fix checks
chris7716 8b3814c
Resolve conflicts
chris7716 a04050f
Addressed comments
chris7716 db8b955
Merge branch 'milestone2.2' of https://github.com/chris7716/oppia int…
chris7716 18058b6
Fix comments
chris7716 687c494
Address comments
chris7716 5c7b82d
Fix dates
chris7716 2146998
Update branch[C
chris7716 42216f4
Fix tests
chris7716 68ddfeb
Update branch[C
chris7716 b01fb27
Fix fe tests
chris7716 d360b8b
Address changes
chris7716 3a707c4
Address changes
chris7716 b24ed22
Address changes
chris7716 496ef43
Address changes
chris7716 31de14a
Address changes
chris7716 6643673
Address changes
chris7716 544acea
Address changes
chris7716 0f0ac82
Address changes
chris7716 9aeff51
Compress svgs
chris7716 e43bb52
Address changes
chris7716 e0709a1
Address changes
chris7716 0225537
Address changes
chris7716 d0e77ff
Address changes
chris7716 85b54fc
Resolve conflicts
chris7716 50d919a
Resolve conflicts
chris7716 31c86d4
Cooment address
chris7716 f8f4426
fix nits
chris7716 bbd2d18
Add logo for the certificate
chris7716 670bfe1
Address eval comments
chris7716 f782890
Update
chris7716 77493b7
Address comments
chris7716 41da8f3
Address comments
chris7716 aba7fe1
Address comments
chris7716 78652f8
Address comments
chris7716 4ca2bdf
Fix lint
chris7716 1cb6391
Fix lint
chris7716 e532dc9
Fix lint
chris7716 3dac23d
Fix lint
chris7716 b5ecdf5
Fix lint
chris7716 b2de5f9
Fix lint
chris7716 9ebc01d
Fix lint
chris7716 38e61d1
Address comments and fix checks
chris7716 ea61791
Address comments and fix checks
chris7716 861661e
Address comments and fix checks
chris7716 5e7db44
Address comments and fix checks
chris7716 66d57a9
Address comments and fix checks
chris7716 597bd42
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 afabab3
Address comments and fix checks
chris7716 c9ef252
Address comments and fix checks
chris7716 ad379ed
Address comments and fix checks
chris7716 fb948aa
Address comments and fix checks
chris7716 0fd619d
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 3d29a00
Address comments and fix checks
chris7716 a6a75ae
Address comments and fix checks
chris7716 3267f34
Address comments and fix checks
chris7716 4206987
Address comments and fix checks
chris7716 ad06a77
Remove lib and use html canvas
chris7716 32b26a4
fix tests
chris7716 40c4bf9
fix tests
chris7716 50e7978
Fix bugs
chris7716 a8b0f5a
Fix nits
chris7716 a9e2b60
Address changes
chris7716 6078309
Address changes
chris7716 d9bc1b6
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 abbbd34
Address changes
chris7716 3a2d442
Address changes
chris7716 e1ac5e1
Resolve conflicts
chris7716 566bf72
Address changes
chris7716 12f3a76
Address changes
chris7716 3f9e963
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 966e1b6
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 27348f3
Address comments
chris7716 c46f507
Fix lint
chris7716 aaf02c0
Fix lint
chris7716 2ca1cb0
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 43c8d6e
Address comments
chris7716 7596dbc
Reduce signature font size
chris7716 aa5f20d
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 1d54ca8
Address comments
chris7716 718a103
Merge branch 'develop' of https://github.com/oppia/oppia into milesto…
chris7716 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will have to use the
self.normalized_request.get('language')
because when generating the question certificate, we do not include language param in the request and it throwsKeyError: 'language'
if we useself.normalized_request['language']
We can get the the default value which is set as
None
if we useself.normalized_request.get('language')
when language is not included in the request.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right, sorry.