Fixes lint issues

oppia · Nik-09 · Nov 23, 2022 · Oct 10, 2022 · Oct 11, 2022 · Oct 11, 2022
commit d5e8301de86c811b34248d95fc63babde93bb728
diff --git a/core/templates/pages/diagnostic-test-player-page/diagnostic-test.model.spec.ts b/core/templates/pages/diagnostic-test-player-page/diagnostic-test.model.spec.ts
@@ -19,7 +19,7 @@
 import { TestBed } from '@angular/core/testing';
 import { DiagnosticTestModelData } from './diagnostic-test.model';
 
-fdescribe('Diagnostic test model', () => {
+describe('Diagnostic test model', () => {
   let diagnosticTestModelData: DiagnosticTestModelData;
   beforeEach(() => {
     TestBed.configureTestingModule({
@@ -37,26 +37,25 @@ fdescribe('Diagnostic test model', () => {
       topicID7: ['topicID2', 'topicID3', 'topicID6'],
       topicID8: ['topicID7'],
       topicID9: ['topicID5', 'topicID8'],
-
-    }
+    };
     diagnosticTestModelData = new DiagnosticTestModelData(
       topicIdToPrerequisiteTopicIds);
   });
 
   it('should be able to get topic ID to ancestor topic IDs', () => {
     const expectedAncestorTopicIds = {
-        topicID1: [],
-        topicID2: ['topicID1'],
-        topicID3: ['topicID2', 'topicID1'],
-        topicID4: ['topicID3', 'topicID2', 'topicID1'],
-        topicID5: ['topicID4', 'topicID3', 'topicID2', 'topicID1'],
-        topicID6: [],
-        topicID7: ['topicID6', 'topicID3', 'topicID2', 'topicID1'],
-        topicID8: [
-          'topicID7', 'topicID6', 'topicID3', 'topicID2', 'topicID1'],
-        topicID9: [
-          'topicID8', 'topicID7', 'topicID6', 'topicID3', 'topicID2',
-          'topicID1', 'topicID5', 'topicID4']
+      topicID1: [],
+      topicID2: ['topicID1'],
+      topicID3: ['topicID2', 'topicID1'],
+      topicID4: ['topicID3', 'topicID2', 'topicID1'],
+      topicID5: ['topicID4', 'topicID3', 'topicID2', 'topicID1'],
+      topicID6: [],
+      topicID7: ['topicID6', 'topicID3', 'topicID2', 'topicID1'],
+      topicID8: [
+        'topicID7', 'topicID6', 'topicID3', 'topicID2', 'topicID1'],
+      topicID9: [
+        'topicID8', 'topicID7', 'topicID6', 'topicID3', 'topicID2',
+        'topicID1', 'topicID5', 'topicID4']
     };
 
     expect(diagnosticTestModelData.getTopicIdToAncestorTopicIds()).toEqual(
@@ -96,4 +95,4 @@ fdescribe('Diagnostic test model', () => {
     expect(diagnosticTestModelData.getEligibleTopicIds()).toEqual(
       expectedEligibleTopicIDs);
   });
-})
+});
diff --git a/core/templates/pages/diagnostic-test-player-page/diagnostic-test.model.ts b/core/templates/pages/diagnostic-test-player-page/diagnostic-test.model.ts
@@ -70,7 +70,8 @@ export class DiagnosticTestModelData {
     this._topicIdToAncestorTopicIds = {};
     for (let topicId in this._topicIdToPrerequisiteTopicIds) {
       let ancestors = [];
-      let prerequisites = cloneDeep(this._topicIdToPrerequisiteTopicIds[topicId]);
+      let prerequisites = cloneDeep(
+        this._topicIdToPrerequisiteTopicIds[topicId]);
 
       while (prerequisites.length > 0) {
         let len = prerequisites.length;
@@ -107,7 +108,7 @@ export class DiagnosticTestModelData {
     this._topicIdToSuccessorTopicIds = {};
     for (let topicid in topicIdToChildTopicId) {
       let successors = [];
-      let children = topicIdToChildTopicId[topicid];
+      let children = cloneDeep(topicIdToChildTopicId[topicid]);
 
       while (children.length > 0) {
         let len = children.length;
@@ -119,7 +120,6 @@ export class DiagnosticTestModelData {
           this._topicIdToSuccessorTopicIds[lastTopicId]);
       }
       this._topicIdToSuccessorTopicIds[topicid] = successors;
-      console.log(this._topicIdToSuccessorTopicIds);
     }
   }