-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #14033: Added Mypy type annotations to some files. #14469
Merged
+490
−191
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
d74038b
Fixes part of #9749: Migrate few instances of angular-html-bind (#14263)
srijanreddy98 354d901
Merge remote-tracking branch 'upstream/develop' into develop
sahiljoster32 7930e4f
Merge remote-tracking branch 'upstream/develop' into develop
sahiljoster32 2ff1fcb
Merge remote-tracking branch 'upstream/develop' into develop
sahiljoster32 7da71af
Merge remote-tracking branch 'upstream/develop' into develop
sahiljoster32 6afee7e
Merge remote-tracking branch 'upstream/develop' into develop
sahiljoster32 f6a3c12
Merge remote-tracking branch 'upstream/develop' into develop
sahiljoster32 5dc96d8
pending with tests
sahiljoster32 bffe408
pending with caching_services
sahiljoster32 f65c8ba
lint 1
sahiljoster32 39fbb95
lint 2
sahiljoster32 c34365a
lint 3
sahiljoster32 7fec54c
pending with test
sahiljoster32 1885375
lint
sahiljoster32 9667b75
done
sahiljoster32 13f1b09
fixed models type
sahiljoster32 8a67ca0
nits
sahiljoster32 c4c2a94
removed conflicts
sahiljoster32 44a0126
added changes
sahiljoster32 d11cfaf
lint 1
sahiljoster32 62b2e5e
lint again :_(
sahiljoster32 9b7a5b5
added changes -1
sahiljoster32 fe36b85
changes -2
sahiljoster32 fd656c8
changes -3
sahiljoster32 28669b1
changes -4
sahiljoster32 94084f6
added changes -3
sahiljoster32 601d151
fixing backend tests
sahiljoster32 44e8825
added changes -4
sahiljoster32 2e91bd8
changes -5
sahiljoster32 c647552
added changes
sahiljoster32 20c8315
Merge remote-tracking branch 'upstream/develop' into mytypes
sahiljoster32 176807f
added literals
sahiljoster32 5252178
added overload decorator
sahiljoster32 6b6ead6
Merge remote-tracking branch 'upstream/develop' into mytypes
sahiljoster32 6a3f29b
added changes
sahiljoster32 1d19b94
added changes
sahiljoster32 4d29919
removed conflicts
sahiljoster32 a85bc4f
added changes -12
sahiljoster32 3d99ce3
added changes
sahiljoster32 53a8d9a
removed merge conflicts
sahiljoster32 e4017ee
lint
sahiljoster32 9537ed6
fixed backend test
sahiljoster32 b943be9
added changes
sahiljoster32 2f62fd9
lint
sahiljoster32 c71a403
added changes
sahiljoster32 d0a9978
test coverage
sahiljoster32 4ca7c69
test coverage -2
sahiljoster32 2840a8a
added overload
sahiljoster32 69cac5d
Update core/domain/caching_services.py
sahiljoster32 995563c
added changes
sahiljoster32 c0b4738
Merge branch 'develop' of https://github.com/oppia/oppia into mytypes
sahiljoster32 b299913
Merge remote-tracking branch 'origin/mytypes' into mytypes
sahiljoster32 085e97e
corrected comment
sahiljoster32 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lint 2
- Loading branch information
commit 39fbb9505f8f6b159e6f343e54f9f5fca6e2b524
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you typing this file? (I'm not against it, just that it wasn't assigned to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because in file
config_domain.py
funcitonset_multi
andget_multi
are called (here:oppia/core/domain/config_domain.py
Line 287 in 6431446
and here
oppia/core/domain/config_domain.py
Line 250 in 6431446
)which are functions defined in
caching_services.py
.so, just to aviod untyped-call error i added annotations to them.
also, this file is not assigned to anyone and most of it's functions are annotated while covering config_domian and it's test file.
so, that's why i added annotations here!!!