Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #11475: Delete all references to continuous jobs #13313

Merged
merged 49 commits into from
Jul 7, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
8aa5eba
Removed notification page
aasiffaizal Jun 22, 2021
33e3baa
Fixed merge conflict file
aasiffaizal Jun 22, 2021
7ef23a8
Fixed ts error
aasiffaizal Jun 22, 2021
2ab9938
Removed notification from accessiblity test
aasiffaizal Jun 23, 2021
b66a685
Fixed JS lint issue
aasiffaizal Jun 23, 2021
1906585
Changed the shortcut for preferenceURL
aasiffaizal Jun 23, 2021
90b42a9
additional nits
aasiffaizal Jun 23, 2021
1a556f6
Fixed ts error
aasiffaizal Jun 23, 2021
2fe54b1
reverting removal of userbackend service
aasiffaizal Jun 23, 2021
726b1a5
Added back the changes
aasiffaizal Jun 23, 2021
7731eaa
Merge remote-tracking branch 'upstream/develop' into notification-remove
aasiffaizal Jun 24, 2021
4fae0e0
Delete FeedbackAnalyticsAggregator
brianrodri Jun 27, 2021
adf3e34
fix unused code
brianrodri Jun 27, 2021
b2c7b78
add PR to note
brianrodri Jun 27, 2021
025fcd7
Merge remote-tracking branch 'upstream/develop' into delete-continuou…
brianrodri Jun 27, 2021
eb164d0
Merge branch 'develop' into notification-remove
brianrodri Jun 27, 2021
0e66e3f
small nit
aasiffaizal Jun 27, 2021
1ff45f1
Merged with develop
aasiffaizal Jun 27, 2021
6aaffff
Merge remote-tracking branch 'upstream/develop' into delete-continuou…
brianrodri Jun 28, 2021
b6317db
address comments
brianrodri Jun 28, 2021
ec65413
Merge remote-tracking branch 'aasiffaizal/notification-remove' into d…
brianrodri Jun 28, 2021
61af3fc
initial attempt
brianrodri Jun 29, 2021
759bbd7
initial attempt
brianrodri Jun 29, 2021
dd80677
Merge branch 'delete-ratings-job' of https://github.com/brianrodri/op…
brianrodri Jun 29, 2021
f5f4f0b
Merge remote-tracking branch 'upstream/develop' into delete-ratings-job
brianrodri Jun 29, 2021
8573689
fix ratings test
brianrodri Jun 29, 2021
12c8891
delete file
brianrodri Jun 30, 2021
d8b6141
reduce untested lines
brianrodri Jun 30, 2021
35014e2
Merge remote-tracking branch 'upstream/develop' into delete-ratings-job
brianrodri Jun 30, 2021
9928240
fix lint
brianrodri Jun 30, 2021
f2cf744
Merge remote-tracking branch 'upstream/develop' into delete-ratings-job
brianrodri Jun 30, 2021
44a9d4c
Merge remote-tracking branch 'upstream/develop' into delete-ratings-job
brianrodri Jun 30, 2021
b07bf2d
remove frontend references to continuous jobs
brianrodri Jun 30, 2021
4dfa567
remove backend references to continuous jobs
brianrodri Jun 30, 2021
c712793
remove checks for events
brianrodri Jun 30, 2021
39f92d3
fix lint
brianrodri Jun 30, 2021
89a1ba1
delete QUEUE_NAME_EVENTS
brianrodri Jul 1, 2021
bd17c53
Merge remote-tracking branch 'upstream/develop' into delete-continuou…
brianrodri Jul 1, 2021
b315062
delete events from queue.yaml
brianrodri Jul 1, 2021
b0e0220
fix bugs
brianrodri Jul 1, 2021
d069d54
fix queue.yaml tests
brianrodri Jul 2, 2021
6530004
Merge remote-tracking branch 'upstream/develop' into delete-continuou…
brianrodri Jul 2, 2021
0c57963
fix coverage
brianrodri Jul 2, 2021
b9c35a7
Merge remote-tracking branch 'upstream/develop' into delete-continuou…
brianrodri Jul 2, 2021
00d0f52
fix lint
brianrodri Jul 2, 2021
f2886ba
Merge remote-tracking branch 'upstream/develop' into delete-ratings-job
brianrodri Jul 3, 2021
f4b4460
Merge branch 'delete-ratings-job' into delete-continuous-references
brianrodri Jul 5, 2021
bba0d7f
Merge remote-tracking branch 'upstream/develop' into delete-continuou…
brianrodri Jul 5, 2021
ba9d2e9
Merge remote-tracking branch 'upstream/develop' into delete-continuou…
brianrodri Jul 5, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added back the changes
  • Loading branch information
aasiffaizal committed Jun 23, 2021
commit 726b1a52aa469f8c5df5efed075b5350d731112b
4 changes: 1 addition & 3 deletions core/templates/services/UpgradedServices.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1141,9 +1141,7 @@ export class UpgradedServices {
upgradedServices['UrlInterpolationService']);
upgradedServices['UserBackendApiService'] =
new UserBackendApiService(
upgradedServices['HttpClient'],
upgradedServices['WindowRef'],
upgradedServices['Title']);
upgradedServices['HttpClient']);
upgradedServices['UserService'] = new UserService(
upgradedServices['UrlInterpolationService'],
upgradedServices['UrlService'],
Expand Down
6 changes: 1 addition & 5 deletions core/templates/services/user-backend-api.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ import { HttpClient } from '@angular/common/http';
import { Injectable } from '@angular/core';
import { downgradeInjectable } from '@angular/upgrade/static';
import { UserInfo, UserInfoBackendDict } from 'domain/user/user-info.model';
import { WindowRef } from './contextual/window-ref.service';
import { Title } from '@angular/platform-browser';

interface SubscriptionSummary {
'creator_picture_data_url': string;
Expand Down Expand Up @@ -59,9 +57,7 @@ export interface UserContributionRightsDataBackendDict {
})
export class UserBackendApiService {
constructor(
private http: HttpClient,
private windowRef: WindowRef,
private titleService: Title) {}
private http: HttpClient) {}

private USER_INFO_URL = '/userinfohandler';
private PROFILE_PICTURE_URL = '/preferenceshandler/profile_picture';
Expand Down