Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructured e2e test script to fix auto restart flaky tests #11186

Closed
wants to merge 4 commits into from
Closed

Restructured e2e test script to fix auto restart flaky tests #11186

wants to merge 4 commits into from

Conversation

DubeySandeep
Copy link
Member

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: [Explain here what your PR does and why]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Nov 13, 2020

Hi @DubeySandeep please assign the required reviewer(s) for this PR. Thanks!

@oppiabot
Copy link

oppiabot bot commented Nov 13, 2020

Hi @DubeySandeep, the body of this PR is missing the required description, please update the body with a description of what this PR does. Thanks!

@DubeySandeep DubeySandeep mentioned this pull request Nov 18, 2020
Closed
4 tasks
@oppiabot
Copy link

oppiabot bot commented Nov 25, 2020

Hi @DubeySandeep, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Nov 25, 2020
@DubeySandeep
Copy link
Member Author

Closing this PR as the existing structure to fetch flaky test data from google-spreadsheet wasn't working on contributors PRs (As the private keys in CIs are not shared on PR builds.). [suppressed by #11263]

@oppiabot oppiabot bot removed the stale label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DubeySandeep DubeySandeep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DubeySandeep