Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11006: Add google as known third-party library #11018

Merged
merged 6 commits into from
Oct 24, 2020
Merged

Fix #11006: Add google as known third-party library #11018

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d72b00a
Add google as known third-party library
U8NWXD Oct 20, 2020
012a8ef
Fix lint errors
U8NWXD Oct 21, 2020
6c5dcc6
Mark google.oauth2 as third-party instead of google
U8NWXD Oct 22, 2020
1c22222
Mark google.protobuf as third party lib
U8NWXD Oct 23, 2020
e35101d
Remove currently unused google.oauth2 from isort.cfg
U8NWXD Oct 23, 2020
f6f11ae
Merge branch 'develop' into fix-lint-sort
U8NWXD Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .isort.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
force_single_line=true
force_sort_within_sections=true
ignore_whitespace=true
known_third_party=browsermobproxy,cloudstorage,google.appengine,jinja2,mapreduce,mutagen,pipeline,pylatexenc,pylint,requests,selenium,skulpt,webapp2,webapp2_extras,webtest,yaml
known_third_party=browsermobproxy,cloudstorage,google.appengine,google.protobuf,jinja2,mapreduce,mutagen,pipeline,pylatexenc,pylint,requests,selenium,skulpt,webapp2,webapp2_extras,webtest,yaml
line_length=80
sections=FUTURE,STDLIB,FIRSTPARTY,THIRDPARTY,LOCALFOLDER
3 changes: 2 additions & 1 deletion core/platform/taskqueue/cloud_taskqueue_services_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@
from core.platform.taskqueue import cloud_taskqueue_services
from core.tests import test_utils
import feconf
from google.protobuf import timestamp_pb2
import python_utils

from google.protobuf import timestamp_pb2


class CloudTaskqueueServicesUnitTests(test_utils.TestBase):
"""Tests for cloud_taskqueue_services."""
Expand Down