Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation bar doesn't open on clicking the hamburger icon #7454

Closed
daksh0225 opened this issue Aug 24, 2019 · 10 comments
Closed

Navigation bar doesn't open on clicking the hamburger icon #7454

daksh0225 opened this issue Aug 24, 2019 · 10 comments
Assignees
@Showtim3

Comments

@daksh0225
Copy link

Describe the bug
The navigation bar doesn't open when the hamburger icon is clicked.
It can be seen on any one of the following pages:
1.)/splash
2.)Learner Dashboard
3.)Notifications
4.)Preferences

To Reproduce
Steps to reproduce the behavior:

  1. Go to any one of the above mentioned pages.
  2. Click on the hamburger icon
  3. The navigation bar doesn't open.

Observed behavior
On clicking the hamburger icon it changes to 'x' but the navigation bar doesn't open. On clicking the 'x' again it changes back to hamburger icon.

Expected behavior
On clicking the hamburger icon the navigation bar should open along with the icon changing to 'x'. On clicking the 'x' icon the navigation bar should collapse and change back to hamburger icon.

Screenshots
Screenshot from 2019-08-25 01-59-03
Screenshot from 2019-08-25 01-59-00
Screenshot from 2019-08-25 01-59-26
Screenshot from 2019-08-25 01-59-24
@daksh0225
Copy link
Author

daksh0225 commented Aug 24, 2019 •
edited
Loading

I would like to solve this issue but i find it very hard to find the right file.

@seanlip seanlip added this to the Blocking bugs milestone Aug 24, 2019
@seanlip
Copy link
Member

seanlip commented Aug 24, 2019

Thanks for reporting @daksh0225. @nithusha21 -- this seems like a blocking bug?

Also, @daksh0225 -- welcome! To get started with Oppia, please follow these instructions. I think @nithusha21 can advise more on whether this is a suitable starter project or not.

@Showtim3
Copy link
Contributor

Showtim3 commented Aug 25, 2019 •
edited
Loading

@seanlip what's happening here? I have solved this issue previously and even my PR is merged solving that. Ok so since this is a blocking bug, I am looking into it.

@Showtim3 Showtim3 self-assigned this Aug 25, 2019
@Showtim3
Copy link
Contributor

@daksh0225 Hey Daksh, how you updated your branch with current develop because i am not able to reproduce this issue. I have tested the sidebar and it is working fine here. Can you please provide some details about the issue?
Screenshot 2019-08-25 at 3 19 06 PM

@daksh0225
Copy link
Author

daksh0225 commented Aug 25, 2019 via email

@seanlip
Copy link
Member

seanlip commented Aug 26, 2019

@Showtim3 Which PR solved this? Has it been merged into the release yet? /cc @nithusha21

@NishealJ
Copy link
Contributor

Hi @seanlip This was resolved in this issue #7125 and was resolved in #7265 .
Also, I have tested this in my bootstrap PR it is working as expected Thanks!

@NishealJ
Copy link
Contributor

I would like to solve this issue but i find it very hard to find the right file.

Hi @daksh0225, you can take up this simple issue #7124, please read the second comment there to know more about which files to change Thanks!

@Showtim3
Copy link
Contributor

@NishealJ @seanlip so maybe we should close this issue right?

@nithusha21
Copy link
Contributor

We'll cherrypick #7265 for the release... /cc @aks681

@ankita240796 ankita240796 removed this from the Blocking bugs milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Showtim3 Showtim3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@seanlip @nithusha21 @ankita240796 @Showtim3 @NishealJ @daksh0225