Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Add remaining I18N keys (Learner Dashboard Redesign) #21554

Open
amyyeung17 opened this issue Dec 28, 2024 · 3 comments
Open

[Feature Request]: Add remaining I18N keys (Learner Dashboard Redesign) #21554

amyyeung17 opened this issue Dec 28, 2024 · 3 comments
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: High Blocks or significantly slows down a core workflow. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@amyyeung17
Copy link
Contributor

Is your feature request related to a problem? Please describe.

This is part of #18384. There are few dynamic text that need to be replaced with I18N keys.

  • add-goals-modal - topic.value for the checkboxes
  • skill-card - subtopic.title, topic.name
  • lesson-card (under summary-tile in components folder) - description

Describe the solution (or solutions) you'd like

N/A

Describe alternatives you've considered and rejected

N/A

Additional context

No response
@amyyeung17 amyyeung17 added triage needed enhancement Label to indicate an issue is a feature/improvement labels Dec 28, 2024
@amyyeung17 amyyeung17 mentioned this issue Dec 28, 2024
Open
@seanlip seanlip added Impact: High Blocks or significantly slows down a core workflow. Work: Low Solution is known and broken into good-first-issue-sized chunks. enhancement Label to indicate an issue is a feature/improvement Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed enhancement Label to indicate an issue is a feature/improvement Work: Low Solution is known and broken into good-first-issue-sized chunks. labels Dec 30, 2024
@seanlip
Copy link
Member

seanlip commented Dec 30, 2024

Note: this is probably blocked on the more general effort to add translations for dynamic content (see #17650, #17649).

@seanlip
Copy link
Member

seanlip commented Dec 30, 2024

@amyyeung17 Just to check, what is "topic.value"? Is it the name of the topic?

@amyyeung17
Copy link
Contributor Author

amyyeung17 commented Dec 31, 2024 •
edited
Loading

@seanlip Oh yes, the keyvalue pipe lets us extract the {key, value} (topic id, topic name) from the for loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: High Blocks or significantly slows down a core workflow. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
LaCE Quality Team
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanlip @amyyeung17