Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Eliminate 'goto()` from the acceptance tests #21491

Open
HardikGoyal2003 opened this issue Dec 20, 2024 · 2 comments
Open

[Feature Request]: Eliminate 'goto()` from the acceptance tests #21491

HardikGoyal2003 opened this issue Dec 20, 2024 · 2 comments
Assignees
@HardikGoyal2003
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Low Solution is known and broken into good-first-issue-sized chunks.

Comments

@HardikGoyal2003
Copy link
Member

Is your feature request related to a problem? Please describe.

Eliminate goto and enhance the tests to better reflect user actions, as goto can behave inconsistently and disrupt the natural user flow.

Describe the solution (or solutions) you'd like

Eliminate goto and do navigation in the natural user flow.

Describe alternatives you've considered and rejected

No response

Additional context

No response
@HardikGoyal2003 HardikGoyal2003 added triage needed enhancement Label to indicate an issue is a feature/improvement labels Dec 20, 2024
@seanlip seanlip mentioned this issue Dec 20, 2024
Merged
5 tasks
@seanlip seanlip added Impact: High Blocks or significantly slows down a core workflow. Work: Low Solution is known and broken into good-first-issue-sized chunks. triage needed and removed Impact: High Blocks or significantly slows down a core workflow. Work: Low Solution is known and broken into good-first-issue-sized chunks. labels Dec 29, 2024
@seanlip
Copy link
Member

seanlip commented Dec 29, 2024

@HardikGoyal2003 I think this needs a bit more clarification. I think it's a good idea to drop some instances of goto() from the tests where performing a user interaction makes more sense. But entering a URL in the browser isn't necessarily wrong in itself.

If this is causing issues in acceptance tests, then would it be possible to update the goto() function in puppeteer-utils to perform the user action of typing the URL properly? Otherwise, it would help to include, in this issue, a checklist of which acceptance tests need to be updated. Could you please clarify the request?

Thanks.

@seanlip
Copy link
Member

seanlip commented Dec 29, 2024

Update: per discussion with @HardikGoyal2003 we will do the following:

  • @HardikGoyal2003 will update our implementation of goto() to actually simulate "typing in a URL".
  • @HardikGoyal2003 will also update this issue to list the specific acceptance test files that need fixing (where goto() should be replaced by some user actions).

@HardikGoyal2003 HardikGoyal2003 self-assigned this Dec 29, 2024
@seanlip seanlip added Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Low Solution is known and broken into good-first-issue-sized chunks. and removed triage needed labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HardikGoyal2003 HardikGoyal2003

Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Low Solution is known and broken into good-first-issue-sized chunks.
Projects
Developer Workflow Team
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanlip @HardikGoyal2003