Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Convert community-lessons tab to progress tab (Learner Dashboard Redesign) #21483

Open
amyyeung17 opened this issue Dec 19, 2024 · 2 comments · May be fixed by #21563
Open

[Feature Request]: Convert community-lessons tab to progress tab (Learner Dashboard Redesign) #21483

amyyeung17 opened this issue Dec 19, 2024 · 2 comments · May be fixed by #21563
Assignees
@amyyeung17
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. target: Q4 2024 Plan to complete by 24 Dec 2024. Work: Low Solution is known and broken into good-first-issue-sized chunks.

Comments

@amyyeung17
Copy link
Contributor

amyyeung17 commented Dec 19, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

This is part of #18384. The community lessons tab serves as the new progress tab for the learner dashboard redesign due to the similarity. There are few changes that need to be made in order to complete the transition.

Describe the solution (or solutions) you'd like

  • Rename community-lesson files to progress
  • Change the i18n keys being used in menu in learner-dashboard. Currently, the menu navigates to the new progress tab using the key associated with the community lessons.
  • Remove loading screen that appears when navigating to it (no new data needs to be loaded when switching over, so this is no longer necessary)

Describe alternatives you've considered and rejected

N/A

Additional context

N/A
@amyyeung17 amyyeung17 added triage needed enhancement Label to indicate an issue is a feature/improvement labels Dec 19, 2024
@amyyeung17 amyyeung17 changed the title [Feature Request]: Converting community-lessons tab to progress tab (Learner Dashboard Redesign) [Feature Request]: Convert community-lessons tab to progress tab (Learner Dashboard Redesign) Dec 19, 2024
@amyyeung17 amyyeung17 mentioned this issue Dec 19, 2024
Open
@HardikGoyal2003
Copy link
Member

Hey @amyyeung17, in this issue, only two tasks need to be completed: renaming the files and changing the I18n keys, right?

@amyyeung17
Copy link
Contributor Author

Hi @HardikGoyal2003, I meant to add one more task. There's a loading screen that needs to be removed. The previous implementation was refetching data, which is no longer the case here.

@HardikGoyal2003 HardikGoyal2003 added the target: Q4 2024 Plan to complete by 24 Dec 2024. label Dec 23, 2024
This was referenced Dec 28, 2024
Closed
Open
@seanlip seanlip added Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Low Solution is known and broken into good-first-issue-sized chunks. labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amyyeung17 amyyeung17

Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. target: Q4 2024 Plan to complete by 24 Dec 2024. Work: Low Solution is known and broken into good-first-issue-sized chunks.
Projects
LaCE Quality Team
Status: Todo
Milestone
No milestone
3 participants
@seanlip @amyyeung17 @HardikGoyal2003