-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Colorize the errors on CI for acceptance tests #21448
Comments
Hi @HardikGoyal2003, |
Hey @mansi-sharma22 Per the guidance at https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue, please provide an explanation of what your PR will do (with names of files you're changing, what you plan to change in each file, etc.). If it looks good, we can assign you to this issue. Please also follow the other instructions on that wiki page if you have not yet done so. Thanks! |
Hi, thanks a lot for your response. This will be my approach. I will also go through the wiki page. Apologies for not having done so already @HardikGoyal2003
|
@mansi-sharma22, could you provide a video demo of your approach? If it looks good, we can assign you. Thanks! |
@HardikGoyal2003 @seanlip because of the Missing Components Solution-: files to Update: -core/tests/puppeteer-acceptance-tests/utilities/jasmine-colored-reporter.ts (new file)
-jasmine.json
-run_acceptance_tests.py
-package.json
This solution will: |
I understand this issue and why this problem is happening. I have made some code changes, specifically in the Can you guide me on how I can test it locally? |
Hey @MadhavDhatrak you can create a test PR, and check it. |
I am running into a issue When I run Mypy checks locally using the following commands, everything works perfectly and I get the "Success: no issues found" message:
However when I try to push to my forked repository the linter tests pass but when Mypy runs, it shows the following errors: Errors from Mypy when pushing: and Much more Thats why I am unable to create the test PR due to the Mypy errors during the push process. |
@MadhavDhatrak Can you please try adding these changes to your PR and push it. |
@seanlip I would like to work on this issue to improve the developer experience by addressing the challenge of identifying acceptance test failures in CI runs. Currently, it is difficult to pinpoint the exact errors without going through the logs manually, which is time-consuming and inefficient. My goal is to enhance the CI logs by implementing a feature that highlights specific errors, similar to how E2E test errors are displayed. This improvement will streamline the debugging process, reduce manual effort, and ensure quicker identification of issues during CI runs. |
@souja450 Per the guidance at https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue, please provide an explanation of what your PR will do (with names of files you're changing, what you plan to change in each file, etc.), as well as a video showing that the changes work correctly on your local machine. We cannot assign you to this (or any issue) without seeing the proof that what you are planning to build actually works. Thanks. |
Hi @seanlip, As per the issue requirements, I plan to enhance error message readability in CI for acceptance tests by adding colorization. Thanks! |
Hello @HardikGoyal2003 @seanlip I have made some changes in the files and I am confident that these changes will resolve the issue. However I am facing some difficulties while testing these changes. I need to create a test PR to verify the fixes, but I’ve been trying for the last two days and am encountering multiple issues. Some of them I’ve already solved, like the mypy test issue, but the problem with the Here is a screenshot of the issue I’m facing: If you have any solutions or suggestions on how to proceed,please let me know. |
@MadhavDhatrak This is a question for GitHub Discussions, not this issue thread. @souja450 Thanks for your update. We'll wait until you have everything set up and working correctly in your local environment before assigning you. |
Hi @seanlip, Regarding the requested feature for colorizing errors in the CI for acceptance tests: I wrote a Python script that uses ANSI codes to add colorization to terminal output. This enhancement improves readability and makes it easier to identify errors in acceptance tests, significantly reducing the time needed to pinpoint issues. New File: scripts/utils/color_utils.py
Implementation:
Testing:
I am currently working on integrating the colorized output functionality into the CI logs for acceptance tests.Files and Updates:
I’ll share a video showing these changes working in my local setup once completed. share any suggestions or solutions for moving forward. Thanks! |
Thanks @Harish-1511. We'll wait for your update that shows that this works properly within the relevant contexts. |
Hello @seanlip sorry for late reply. This is the video demo for my work. Uploading Testingvideo1.mov… |
Hello @seanlip sorry for late reply. This is the video demo for my work. Uploading Testingvideo1.mov… |
@souja450 The video demo in your previous comments is not properly uploaded, making it invisible. Additionally, your last email reply is unclear. Could you please clarify? Thanks! |
I couldn't upload it in good quality. The size should be less than 10 MB.
Regards,
Soulaimene
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Hardik Goyal ***@***.***>
Sent: Friday, December 27, 2024 10:21:03 PM
To: oppia/oppia ***@***.***>
Cc: Soulaimene Jaoua ***@***.***>; Mention ***@***.***>
Subject: Re: [oppia/oppia] [Feature Request]: Colorize the errors on CI for acceptance tests (Issue #21448)
@souja450<https://github.com/souja450> The video demo in your previous comments is not properly uploaded, making it invisible. Additionally, your last email reply is unclear. Could you please clarify? Thanks!
—
Reply to this email directly, view it on GitHub<#21448 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BM4JGHCC3NKKS3RKF6ITUV32HWSB7AVCNFSM6AAAAABTVH2746VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRTHE3DQMZZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @seanlip, As per the issue requirements, I did those changes: Testingvideo1.mov |
@souja450 Thanks, I can't see your video clearly enough and I don't think it is actually running the acceptance tests. I suggest doing the following:
Hope this helps. |
Hello @seanlip Please find attached my video demo on parts. videopart1.movvideopart2.movvideopart3--.movvideopart4--.mov |
@souja450 This doesn't follow the guidance I provided above. You are still recording the entire screen and you haven't shown that you have gotten to the "acceptance tests" section yet. |
@seanlip please find attached the terminal video here. full_video.mov |
@souja450 That's better, yup. You still haven't successfully got to the point of running an acceptance test, though. Please don't post more videos in this thread until you've sorted that out. |
@seanlip hello I just got the acceptance test passed. |
No, they have not passed. You have run 0 tests. Your logs should look something like the ones here: https://github.com/oppia/oppia/actions/runs/12543790205/job/34979432783 |
Hello @seanlip Happy new year when I compile python -m scripts.run_e2e_tests it generates those errors. Can u help me fixing those every time I need to install requirement.txt I followed the instruction on wiki page but it couldn't be resolved. |
I need help I tried to compile but always there is a requirement dependency file that check which creates conflicts how to fix it_ |
@seanlip Hello the environment is set up but when it reaches the testing of acceptance test it shows like python dependencies are missing despite I installed requirement.txt and requirement_dev.txt. what could be the possible solution? |
Hi @seanlip please find attched the test suites running and the environment setup running too. |
Hi @souja450, that's great, but these are the e2e tests, not the acceptance tests. You'll want to try running the acceptance tests. See our wiki for more details. Also I would suggest that you refrain from posting more images on this thread until you have the colourization actually working, i.e. you have actually solved the issue. You can use GitHub Discussions instead if you have general dev-workflow-related questions. Thanks. |
Is your feature request related to a problem? Please describe.
It's challenging to identify the exact error for acceptance test fails in the CI run failure; we need to look at it closely, which is time-consuming.
Describe the solution (or solutions) you'd like
Highlight the errors on the CI similar to the E2E tests
Describe alternatives you've considered and rejected
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: