-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Drop inactive contributors from issues that they aren't working on. #21294
Comments
Hey @seanlip I got a solution in my mind with oppia bot method
|
Thanks @Ashu463. Same comment as for other issues, we need to see proof of this working before we can assign you to the issue. |
@seanlip Sure raising it's full PR soon. Actually while opening last PR maintainer said to open PR after it gets assigned so did nothing with this issue other than proposing solution. |
Just to be clear, I'm not asking you to make a PR, but to show proof that your solution is working. You can do that on your own test repository, for example. See oppia/stale-review-request-notifier#4 (comment) for an example of how to do this. |
Ahh got it, will share you soon. |
Hey @seanlip I am done with my work but needed to add some dependencies over requirements.txt file which I'm not allowed for. |
Yeah I do need help to test it over demo repo, would you pls help @SD-13 ? |
@Ashu463 I need more context about your changes, do you have them locally? If yes, can you push them to remote and share? |
Hey @SD-13 I do have them all changes locally but can't push it due to not having access to change requirements.txt althrough I can push without it so if u want then pls let me know. |
@seanlip isn't there any oppia's slack or discord or community channel where I can ask you about issues in private msgs ? |
@Ashu463 My understanding is your changes doesn't have any dependency on the rest of the repo, so I think you can -
Let me know if you have any questions. Thanks! |
Hey @SD-13 thanks for your help, here is how I did on my own fork and chosen another method which do not require to update requirements file.
Screencast.from.2024-11-23.17-57-21.mp4 |
@seanlip please have a look over solution video, I hope it solves issue and if anything else needed then pls let me know. |
@Ashu463 Can't see your video. |
@SD-13 Idk why this error occurs but here is the link of video uploaded online, for convenience I'm sharing link of that opened issue as well here it is |
Hi @Ashu463, we use GitHub Discussions for general questions. I'm afraid we generally don't do private messages -- in general we try to avoid those and have discussions in the open instead, where possible. This makes it easier for other folks on the team to help as well. Re your video, I think you have the basic behaviour right, but I have a few questions (please take a look at the original issue description, too). Could you please explain your approach and/or provide demos for them?
|
Hi @seanlip I would like to inform you that my end semester exams has started so my contributions could be less, but as far as your questions are concerned here are the answers to them :
|
@Ashu463 OK, thanks for the update. Just a note -- when you share the demos, please also explain the logic behind how you plan to tackle questions 1 and 2 as well (what API calls you use, how you will determine whether the assignee has a PR that actually corresponds to the issue). Thanks! |
Hey @seanlip here is the detailed explanation along with demo videos =>
|
@Ashu463 For (1) it looks good, but for (2) your video doesn't load and after a while redirects me to the kapwing homepage. It would be good to understand the logic here better -- can you try posting it again, please? Thanks. |
@Ashu463 Thanks! I think this looks reasonable, feel free to open a PR :) We can dig into the implementation more at the review stage, but at this point I think you have a good idea of what is going on with the main parts of the issue so I'm happy to assign it to you. Thanks for taking a look! |
Thanks for assigning @seanlip ,will raise the PR soon. |
Hey @seanlip I had opened up the PR, now you can see the exact changes I made in solution. |
@seanlip now I opened PR with proper description, so PTAL! |
Is your feature request related to a problem? Please describe.
We have run into some cases where a new contributor gets assigned to an issue but then disappears, e.g. #20564 (comment).
In such cases, we should automatically deassign the contributor so that the issue is available for others to take up.
Describe the solution (or solutions) you'd like
We should have a workflow (GitHub Actions or Oppiabot) that runs every week and does the following:
Note that we exclude Oppia members and collaborators from this check, because typically they may take on harder issues which require more than one week between milestones. On the other hand, new contributors typically take starter issues which are only assigned to them after they have proposed a working solution.
Describe alternatives you've considered and rejected
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: