Fix #4292: Upgraded font-awesome and play/pause icons (#4750)

* upgraded font awesome * fixed size of icons
oppia · Mar 1, 2018 · 38754ba · 38754ba
1 parent 03863c1
commit 38754ba
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/app.yaml b/app.yaml
@@ -164,7 +164,7 @@ skip_files:
 - third_party/static/angular-audio-1.7.4
 - third_party/static/angular-scroll-1.0.0
 - third_party/static/angular-toastr-1.7.0
-- third_party/static/font-awesome-4.4.0
+- third_party/static/font-awesome-4.7.0
 - third_party/static/messageformat-0.3.1
 - third_party/static/ng-img-crop-0.3.2
 - third_party/static/nginfinitescroll-1.0.0

diff --git a/core/templates/dev/head/pages/exploration_player/audio_bar_directive.html b/core/templates/dev/head/pages/exploration_player/audio_bar_directive.html
@@ -3,7 +3,7 @@
     <div style="width: 560px;">
       <i class="fa audio-controls-button-icon"
          ng-click="onPlayButtonClicked()"
-         ng-class="{'fa-ellipsis-h': audioLoadingIndicatorIsShown, 'fa-play': !isAudioPlaying(), 'fa-pause': isAudioPlaying(), 'audio-controls-audio-not-available': !isAudioAvailableInCurrentLanguage() || audioIsLoading}"
+         ng-class="{'fa-ellipsis-h': audioLoadingIndicatorIsShown, 'fa-play-circle': !isAudioPlaying(), 'fa-pause-circle': isAudioPlaying(), 'audio-controls-audio-not-available': !isAudioAvailableInCurrentLanguage() || audioIsLoading}"
          uib-tooltip="<[!isAudioAvailableInCurrentLanguage() ? ('I18N_PLAYER_AUDIO_NOT_AVAILABLE_IN' | translate:{languageDescription:getCurrentAudioLanguageDescription()}) : '']>"
          tooltip-append-to-body="true" tooltip-placement="right"></i>
       <div class="slider-section" ng-if="hasPressedPlayButtonAtLeastOnce">
@@ -32,6 +32,14 @@
 
 <style>
 
+  .fa-play-circle:before {
+    font-size: 1.7em;
+  }
+
+  .fa-pause-circle:before {
+    font-size: 1.7em;
+  }
+
   audio-bar md-progress-linear.md-default-theme .md-bar {
     background-color: #009688;
   }

diff --git a/manifest.json b/manifest.json
@@ -245,9 +245,9 @@
         }
       },
       "fontAwesome": {
-        "version": "4.4.0",
+        "version": "4.7.0",
         "downloadFormat": "zip",
-        "url": "https://github.com/FortAwesome/Font-Awesome/archive/v4.4.0.zip",
+        "url": "https://github.com/FortAwesome/Font-Awesome/archive/v4.7.0.zip",
         "rootDirPrefix": "Font-Awesome-",
         "targetDirPrefix": "font-awesome-",
         "bundle": {