Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: Activate CONFIG_NET_SWITCHDEV in generic config #17668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hauke
Copy link
Member

@hauke hauke commented Jan 19, 2025

The CONFIG_NET_SWITCHDEV option is needed by CONFIG_DSA and some other
options. It is boolean, we have to compile it into the kernel it self.
Activate it for all targets in the generic configuration, it is already
activated for most of them. This allows to install DSA drivers as a
module.

The CONFIG_NET_SWITCHDEV option is needed by CONFIG_DSA and some other
options. It is boolean, we have to compile it into the kernel it self.
Activate it for all targets in the generic configuration, it is already
activated for most of them. This allows to install DSA drivers as a
module.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
@hauke
Copy link
Member Author

hauke commented Jan 19, 2025

@tk154 Please check if the mellanox driverstill works.

@github-actions github-actions bot added target/apm821xx pull request/issue for apm821xx target target/at91 pull request/issue for at91 target target/bcm53xx pull request/issue for bcm53xx target target/ipq806x pull request/issue for ipq806x target kernel pull request/issue with Linux kernel related changes target/kirkwood pull request/issue for kirkwood target target/lantiq pull request/issue for lantiq target target/layerscape pull request/issue for layerscape target target/mpc85xx pull request/issue for mpc85xx target target/mvebu pull request/issue for mvebu target target/octeon pull request/issue for octeon target target/omap pull request/issue for omap target core packages pull request/issue for core (in-tree) packages target/ramips pull request/issue for ramips target target/sunxi pull request/issue for sunxi target target/imx pull request/issue for imx (imx6) target target/ipq40xx pull request/issue for ipq40xx target target/ath79 pull request/issue for ath79 target target/mediatek pull request/issue for mediatek target target/gemini pull request/issue for gemini target target/rockchip pull request/issue for rockchip target target/realtek pull request/issue for realtek target target/bmips pull request/issue for bmips target target/bcm4908 pull request/issue for bcm4908 target target/qoriq pull request/issue for qoriq target target/airoha pull request/issue for airoha target target/qualcommax pull request/issue for qualcommax target target/siflower pull request/issue for siflower target labels Jan 19, 2025
@github-actions github-actions bot added the target/ixp4xx pull request/issue for ixp4xx target label Jan 19, 2025
@namiltd
Copy link
Contributor

namiltd commented Jan 19, 2025

Some targets like e.g. ramips/mt7620 work without DSA so CONFIG_NET_SWITCHDEV should not be enabled for them.

@hauke
Copy link
Member Author

hauke commented Jan 19, 2025

I reduced this to the CONFIG_NET_SWITCHDEV change now.

@hauke
Copy link
Member Author

hauke commented Jan 20, 2025

Some targets like e.g. ramips/mt7620 work without DSA so CONFIG_NET_SWITCHDEV should not be enabled for them.

Yes this will increase the kernel size for some targets which are not needing it. This also provides us the possibility to build DSA as a kernel module on all targets. The Mellanox driver was activating it anyway for most targets in the past.

@hauke hauke changed the title Kconfig cleanups kernel: Activate CONFIG_NET_SWITCHDEV in generic config Jan 20, 2025
@namiltd
Copy link
Contributor

namiltd commented Jan 20, 2025

It would be useful to know how much the kernel is increased by. For routers with 8MB flash, every kb is important.

@namiltd
Copy link
Contributor

namiltd commented Jan 20, 2025

On the ramips/mt7620 target the kernel has grown by 4.5kB.

@hauke
Copy link
Member Author

hauke commented Jan 20, 2025

On the ramips/mt7620 target the kernel has grown by 4.5kB.

Thanks for measuring this. Was this compressed or uncompressed?

@namiltd
Copy link
Contributor

namiltd commented Jan 20, 2025

@hauke openwrt-ramips-mt7620-router_name-initramfs-kernel.bin

@tk154
Copy link
Contributor

tk154 commented Jan 20, 2025

@tk154 Please check if the mellanox driverstill works.

Hi, the Mellanox driver still works on our Switches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages kernel pull request/issue with Linux kernel related changes target/airoha pull request/issue for airoha target target/apm821xx pull request/issue for apm821xx target target/at91 pull request/issue for at91 target target/ath79 pull request/issue for ath79 target target/bcm53xx pull request/issue for bcm53xx target target/bcm4908 pull request/issue for bcm4908 target target/bmips pull request/issue for bmips target target/gemini pull request/issue for gemini target target/imx pull request/issue for imx (imx6) target target/ipq40xx pull request/issue for ipq40xx target target/ipq806x pull request/issue for ipq806x target target/ixp4xx pull request/issue for ixp4xx target target/kirkwood pull request/issue for kirkwood target target/lantiq pull request/issue for lantiq target target/layerscape pull request/issue for layerscape target target/mediatek pull request/issue for mediatek target target/mpc85xx pull request/issue for mpc85xx target target/mvebu pull request/issue for mvebu target target/octeon pull request/issue for octeon target target/omap pull request/issue for omap target target/qoriq pull request/issue for qoriq target target/qualcommax pull request/issue for qualcommax target target/ramips pull request/issue for ramips target target/realtek pull request/issue for realtek target target/rockchip pull request/issue for rockchip target target/siflower pull request/issue for siflower target target/sunxi pull request/issue for sunxi target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants