mt76: fixes for memory leak and kernels 6.7 and above #17662
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to make these patches on the page https://github.com/openwrt/mt76 but the "Pull requests" tab on this page is dead, not verified by anyone. |
github-actions
bot
added
the
core packages
|
i believe you need to use upstream linux-wireless @nbd168 ? |
|
mt76 is provided by mac80211, not the kernel. |
Noltari
reviewed
Jan 20, 2025
Noltari
reviewed
Jan 20, 2025
package/kernel/mt76/patches/0002-fix allocation check and missing memory freeing.patch
Outdated
Show resolved
Hide resolved
|
@namiltd I think that we should wait until openwrt/mt76#947 and openwrt/mt76#948 are merged in the mt76 repo and then bump the mt76 revision. |
|
@Noltari One of those PRs was there for a month (as openwrt/mt76#938) and no one looked at it. I hope it will be faster here. |
The PP_FLAG_PAGE_FRAG constant was removed in kernel 6.7, so we are removing it from code for kernels 6.7 and above. Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Fixed allocation checking and freeing buffer memory inside mt76_eeprom_changes() function. Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix kernel 6.7 compatibility:
The PP_FLAG_PAGE_FRAG constant was removed in kernel 6.7, so we are removing it from code for kernels 6.7 and above.
This is needed for building the openwrt with the next LTS kernel 6.12.
Fix allocation check and missing memory freeing:
Fixed allocation checking and freeing buffer memory inside mt76_eeprom_changes() function.