Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Add row weights to the fix top bar icons being hidden when text is too big #3669

Merged
merged 4 commits into from
Dec 20, 2024
Merged

🐛 Add row weights to the fix top bar icons being hidden when text is too big #3669

merged 4 commits into from
Dec 20, 2024

Conversation

dubdabasoduba
Copy link
Member

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/onaio/fhir-resources/issues/3700

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@dubdabasoduba dubdabasoduba self-assigned this Dec 20, 2024
Rkareko
Rkareko previously approved these changes Dec 20, 2024
View reviewed changes
Lentumunai-Mark
Lentumunai-Mark previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@Lentumunai-Mark Lentumunai-Mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.9%. Comparing base (f2b8910) to head (7aaf66e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rcore/quest/ui/main/components/TopScreenSection.kt 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3669   +/-   ##
=======================================
  Coverage     38.9%   38.9%           
- Complexity    1159    1160    +1     
=======================================
  Files          284     284           
  Lines        15060   15060           
  Branches      2669    2669           
=======================================
+ Hits          5860    5861    +1     
  Misses        8356    8356           
+ Partials       844     843    -1
Flag Coverage Δ
engine 62.5% <ø> (ø)
geowidget 16.0% <ø> (ø)
quest 25.1% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rcore/quest/ui/main/components/TopScreenSection.kt 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

@dubdabasoduba dubdabasoduba merged commit 3c3dea1 into main Dec 20, 2024
4 of 5 checks passed
@dubdabasoduba dubdabasoduba deleted the feature/fix_top_bar branch December 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lentumunai-Mark Lentumunai-Mark Lentumunai-Mark approved these changes

@Rkareko Rkareko Rkareko approved these changes

Assignees

@dubdabasoduba dubdabasoduba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dubdabasoduba @Rkareko @Lentumunai-Mark