add tests

opensrp · sevenreup · Aug 1, 2023 · Apr 26, 2023 · May 26, 2023 · Jun 5, 2023
commit 3718c03be44760fd4ae11dcb04ac5b01ab87462b
diff --git a/...rc/test/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistryTest.kt b/...rc/test/java/org/smartregister/fhircore/engine/configuration/ConfigurationRegistryTest.kt
@@ -19,6 +19,8 @@ package org.smartregister.fhircore.engine.configuration
 import android.content.Context
 import androidx.test.core.app.ApplicationProvider
 import com.google.android.fhir.FhirEngine
+import com.google.android.fhir.db.ResourceNotFoundException
+import com.google.android.fhir.logicalId
 import com.google.android.fhir.search.Search
 import dagger.hilt.android.testing.BindValue
 import dagger.hilt.android.testing.HiltAndroidRule
@@ -240,4 +242,44 @@ class ConfigurationRegistryTest : RobolectricTest() {
       }
     Assert.assertFalse(configurationRegistry.isWorkflowPoint(sectionComponent))
   }
+
+  @Test
+  @ExperimentalCoroutinesApi
+  fun testAddOrUpdate() {
+    // when does not exist
+    val patient = Faker.buildPatient()
+    coEvery { fhirEngine.get(patient.resourceType, patient.logicalId) } returns patient
+    coEvery { fhirEngine.update(any()) } returns Unit
+
+    runTest {
+      val previousLastUpdate = patient.meta.lastUpdated
+      configurationRegistry.addOrUpdate(patient)
+      Assert.assertNotEquals(previousLastUpdate, patient.meta.lastUpdated)
+    }
+
+    // when exists
+    runTest {
+      val previousLastUpdate = patient.meta.lastUpdated
+      configurationRegistry.addOrUpdate(patient)
+      Assert.assertNotEquals(previousLastUpdate, patient.meta.lastUpdated)
+    }
+  }
+
+  @Test
+  @ExperimentalCoroutinesApi
+  fun testAddOrUpdateCatchesResourceNotFound() {
+    val patient = Faker.buildPatient()
+    coEvery { fhirEngine.get(patient.resourceType, patient.logicalId) } throws
+      ResourceNotFoundException("", "")
+    coEvery { fhirEngine.create(any()) } returns listOf()
+
+    runTest {
+      val previousLastUpdate = patient.meta.lastUpdated
+      configurationRegistry.addOrUpdate(patient)
+      Assert.assertNotEquals(previousLastUpdate, patient.meta.lastUpdated)
+    }
+
+    coVerify(inverse = true) { fhirEngine.update(any()) }
+    coVerify { fhirEngine.create(patient) }
+  }
 }
diff --git a/...org/smartregister/fhircore/engine/data/remote/fhir/resource/FhirResourceDataSourceTest.kt b/...org/smartregister/fhircore/engine/data/remote/fhir/resource/FhirResourceDataSourceTest.kt
@@ -19,21 +19,18 @@ package org.smartregister.fhircore.engine.data.remote.fhir.resource
 import io.mockk.coEvery
 import io.mockk.mockk
 import io.mockk.spyk
-import kotlinx.coroutines.test.runBlockingTest
+import kotlinx.coroutines.ExperimentalCoroutinesApi
+import kotlinx.coroutines.test.runTest
 import org.hl7.fhir.r4.model.Bundle
 import org.hl7.fhir.r4.model.OperationOutcome
 import org.hl7.fhir.r4.model.Patient
 import org.hl7.fhir.r4.model.ResourceType
 import org.junit.Assert
 import org.junit.Before
-import org.junit.Rule
 import org.junit.Test
-import org.smartregister.fhircore.engine.rule.CoroutineTestRule
 
+@OptIn(ExperimentalCoroutinesApi::class)
 class FhirResourceDataSourceTest {
-
-  @get:Rule(order = 1) val coroutineTestRule = CoroutineTestRule()
-
   private val resourceService: FhirResourceService = mockk()
 
   private lateinit var fhirResourceDataSource: FhirResourceDataSource
@@ -45,16 +42,16 @@ class FhirResourceDataSourceTest {
 
   @Test
   fun testLoadDataShouldRetrieveResource() {
-    coroutineTestRule.runBlockingTest {
+    runTest {
       val bundle = Bundle()
       coEvery { resourceService.getResource(any()) } returns bundle
-      Assert.assertEquals(bundle, fhirResourceDataSource.loadData("http://fake.url"))
+      Assert.assertEquals(bundle, fhirResourceDataSource.getResource("http://fake.url"))
     }
   }
 
   @Test
   fun testInsertShouldAddResource() {
-    coroutineTestRule.runBlockingTest {
+    runTest {
       val resource = Patient()
       coEvery { resourceService.insertResource(any(), any(), any()) } returns resource
       Assert.assertEquals(
@@ -66,7 +63,7 @@ class FhirResourceDataSourceTest {
 
   @Test
   fun testUpdateShouldUpdateResource() {
-    coroutineTestRule.runBlockingTest {
+    runTest {
       val operationOutcome = OperationOutcome()
       coEvery { resourceService.updateResource(any(), any(), any()) } returns operationOutcome
       Assert.assertEquals(
@@ -79,7 +76,7 @@ class FhirResourceDataSourceTest {
   @Test
   fun testDeleteShouldRemoveResource() {
 
-    coroutineTestRule.runBlockingTest {
+    runTest {
       val operationOutcome = OperationOutcome()
       coEvery { resourceService.deleteResource(any(), any()) } returns operationOutcome
       Assert.assertEquals(
@@ -91,7 +88,7 @@ class FhirResourceDataSourceTest {
 
   @Test
   fun testSearchResourceShouldReturnBundle() {
-    coroutineTestRule.runBlockingTest {
+    runTest {
       val bundle = Bundle()
       coEvery { resourceService.searchResource(any(), any()) } returns bundle
       Assert.assertEquals(

diff --git a/...e/src/test/java/org/smartregister/fhircore/engine/util/extension/ResourceExtensionTest.kt b/...e/src/test/java/org/smartregister/fhircore/engine/util/extension/ResourceExtensionTest.kt
@@ -714,4 +714,15 @@ class ResourceExtensionTest : RobolectricTest() {
     carePlan.addTags(meta)
     Assert.assertTrue(carePlan.meta.tag.isEmpty())
   }
+
+  @Test
+  fun logicalIdFromFhirPathExtractedIdReturnsCorrectValue() {
+    val logicalId = "Group/0acda8c9-3fa3-40ae-abcd-7d1fba7098b4/_history/2"
+    Assert.assertEquals("0acda8c9-3fa3-40ae-abcd-7d1fba7098b4", logicalId.extractLogicalIdUuid())
+    val otherLogicalId = "Group/0acda8c9-3fa3-40ae-abcd-7d1fba7098b4"
+    Assert.assertEquals(
+      "0acda8c9-3fa3-40ae-abcd-7d1fba7098b4",
+      otherLogicalId.extractLogicalIdUuid()
+    )
+  }
 }