Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Upgrade NPM deps to latest versions #1179

Merged
merged 4 commits into from
Sep 22, 2021
Merged

[UI] Upgrade NPM deps to latest versions #1179

merged 4 commits into from
Sep 22, 2021

Conversation

cardil
Copy link
Member

@cardil cardil commented Aug 30, 2021

Still, the cypress patch needs to be there. The cypress-io/cypress#17288 isn't fixed yet.

@openshift-ci openshift-ci bot requested review from jcrossley3 and matzew August 30, 2021 14:17
@cardil
Copy link
Member Author

cardil commented Aug 30, 2021

/cc @mgencur
/cc @jrangelramos

@openshift-ci openshift-ci bot requested review from jrangelramos and mgencur August 30, 2021 14:17
@cardil cardil changed the title Upgrade NPM deps to latest versions [UI] Upgrade NPM deps to latest versions Aug 30, 2021
@cardil
Copy link
Member Author

cardil commented Sep 16, 2021

/area qe

@openshift-ci openshift-ci bot added the area/qe Quality Engineering related things label Sep 16, 2021
@cardil
Copy link
Member Author

cardil commented Sep 21, 2021 •
edited
Loading

Latest commit 308e061 fixes CVE-2021-3807

References:

@cardil
Copy link
Member Author

cardil commented Sep 21, 2021

/hold

I'd like to test if everything works well with overridden deps

@cardil
Copy link
Member Author

cardil commented Sep 21, 2021

It works. Yey!

/unhold
/cc @markusthoemmes

@cardil cardil force-pushed the feature/upgrade-npm-deps branch from 4a85b73 to 9925ea5 Compare September 21, 2021 15:51
@cardil cardil force-pushed the feature/upgrade-npm-deps branch from 9925ea5 to 308e061 Compare September 21, 2021 15:54
@jrangelramos
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 21, 2021
@cardil
Copy link
Member Author

cardil commented Sep 21, 2021

To fully fix the CVE-2021-3807, someone needs to update GitHub Advisory Database to properly set affected versions field. It should be set to >=6.0.0 <6.0.1 || <5.0.1 (instead of <6.0.1) like is set properly on https://app.snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908

I've raised that on upstream, see: chalk/ansi-regex#38 (comment).

markusthoemmes
markusthoemmes approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, jrangelramos, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 36228a4 into openshift-knative:main Sep 22, 2021
@cardil cardil deleted the feature/upgrade-npm-deps branch September 22, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

@matzew matzew Awaiting requested review from matzew

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@markusthoemmes markusthoemmes

@jrangelramos jrangelramos

Labels
approved area/qe Quality Engineering related things lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cardil @jrangelramos @markusthoemmes @openshift-merge-robot