This repository has been archived by the owner on Aug 2, 2019. It is now read-only.
Update installation-functions.sh #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore headers. Simplify what grep is checking
jcrossley3
reviewed
May 14, 2019
| @@ -30,7 +30,7 @@ function timeout() { | |||
|
|
|||
| # Waits for all pods in the given namespace to complete successfully. | |||
| function wait_for_all_pods { | |||
| timeout 300 "$CMD get pods -n $1 && [[ \$($CMD get pods -n $1 2>&1 | grep -c -v -E '(Running|Completed|Terminating|STATUS)') -eq 0 ]]" | |||
| timeout 300 "$CMD get pods -n $1 && [[ \$($CMD get pods -n $1 2>&1 --no-headers | grep -c -v -E '(Running|Completed|Terminating)') -eq 0 ]]" | |||
There was a problem hiding this comment.
Safe to assume that option is available for all expected versions of kubectl and oc?
There was a problem hiding this comment.
Looking to see what version of kubectl it was introduced in
There was a problem hiding this comment.
It was introduced in v1.4. Very confusingly, the documentation specifies --no-header, even when discussed within the PR itself, but the code specifies "no-headers". Search no header on v1.4 Release docs. PR
There was a problem hiding this comment.
Good enough for me! We'll see if anyone complains. Thanks again!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore headers. Simplify what grep is checking