-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pullthrough serve blob #9796
Fix pullthrough serve blob #9796
Conversation
Tested manually with |
Looks like flake #9775
[test] |
@legionus PTAL |
@miminar Can you add integration test for that ? |
@legionus would a unit test do? |
I think you can use any test that checks for this. |
@miminar do we need to backport this? |
@mfojtik it would be nice. Once merged, I'll do the backport. I haven't yet got the chance to finish the tests though. |
d5a6fde
to
1eece67
Compare
@smarterclayton fyi |
LGTM @mfojtik We need to backport it. |
LGTM |
let's get the blob ACL PR in first |
Yeah, it will conflict for sure. |
1eece67
to
c40ffaa
Compare
c40ffaa
to
b70c24c
Compare
b70c24c
to
8113c24
Compare
I just don't know, how to defeat |
@miminar as the bot requests, you need to have the failed Jenkins job link. The sentence telling you that this link is necessary also has a hyperlink to the failed job it is searching for. This job is the job that was triggered by the bot, so it will be |
@stevekuznetsov thanks! That's 1:0 for the bot. I'm sure I'll win next time. |
Flake #10274. Job https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7632/ |
@miminar I'm actually impressed, with your newest comment you found two other bugs in the bot ... I didn't even realize the first way you linked to an issue was a valid thing ... give me a moment. |
I'm always glad to help. 😄 |
Signed-off-by: Michal Minář <miminar@redhat.com>
Signed-off-by: Michal Minář <miminar@redhat.com>
8113c24
to
7d4051e
Compare
Don't attempt to copy any data on a HEAD. Signed-off-by: Michal Minar <miminar@redhat.com>
7d4051e
to
1245726
Compare
Evaluated for origin test up to 1245726 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7902/) |
@mfojtik can you please merge? |
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7919/) (Image: devenv-rhel7_4829) |
Evaluated for origin merge up to 1245726 |
Don't attempt to copy any data on a HEAD.
Closes #8613