Preserve scaling factor of prior deployment #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scaling up a new deployment and a prior deployment exists, preserve the replica count of the prior deployment. If no prior deployment exists, use the template replica count.
|
@ironcladlou overall LGTM |
| // DesiredReplicasAnnotation represents the desired number of replicas for a | ||
| // new deployment. | ||
| // TODO: This should be made public upstream. | ||
| DesiredReplicasAnnotation = "kubectl.kubernetes.io/desired-replicas" |
There was a problem hiding this comment.
Is there an issue or pull for that?
There was a problem hiding this comment.
Will do that now.
There was a problem hiding this comment.
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/1825/) (Image: devenv-fedora_1451) |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/2037/) |
|
Evaluated for origin up to 64ee9f7 |
openshift-bot
pushed a commit
that referenced
this pull request
May 6, 2015
…tor-2 Merged by openshift-bot
This was referenced May 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scaling up a new deployment and a prior deployment exists,
preserve the replica count of the prior deployment. If no prior
deployment exists, use the template replica count.