Enable gzip compression #18124
Enable gzip compression #18124
Conversation
openshift-ci-robot
added
approved
openshift-merge-robot
added
the
vendor-update
|
if you're ready, I'm ready. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
yup, all set |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
(the failures seems to be related to getting logs from failed hook pods, which is related to journald i believe). |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
hmm... that's slightly suspicious... there was an issue upstream about streaming logs with this feature enabled kubernetes/kubernetes#54205 (comment) |
|
@liggitt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold yeah... all five runs failed with that logs error I don't see that logs error occur on job failures on other PRs @ilackarms FYI, enabling compression seems to break another logs case |
openshift-ci-robot
added
the
do-not-merge/hold
|
moved this out of the 3.9 milestone, hold this PR until kube 1.10. |
No description provided.