Use shared informers for secrets, services, and service accounts #14086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
force-pushed
the
secret_reuse
branch
3 times, most recently
from
aca19b0 to
123cdd2
Compare
0xmichalis
reviewed
May 6, 2017
| // set. | ||
| func (c *NamespaceSecurityDefaultsController) allocate(ns *kapi.Namespace) error { | ||
| tx := &tx{} | ||
| defer tx.Rollback() |
There was a problem hiding this comment.
These defers do not need to run before uid allocation.
|
But they're free and can't accidentally be broken here.
|
smarterclayton
force-pushed
the
secret_reuse
branch
4 times, most recently
from
87a9065 to
a564213
Compare
|
[test] |
|
Two log rate limit(?) related flakes and one compile [test]
|
|
@smarterclayton #14122 re[test] |
|
[test] super happy that this is mostly going green |
|
[test] might be flakes
…On Thu, May 11, 2017 at 1:37 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1356/)
(Base Commit: 2628c77
<2628c77>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14086 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pykN6BOdMAxOPHVo2E4sAHkYEDWwks5r40djgaJpZM4NShCI>
.
|
|
[test] startup flake
…On Thu, May 11, 2017 at 5:38 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1369/)
(Base Commit: 2628c77
<2628c77>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14086 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p_0_EPOSEyrjJKhm_wgLzMqqcA77ks5r43--gaJpZM4NShCI>
.
|
|
more [test] to counter flake.
…On Thu, May 11, 2017 at 9:43 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test SUCCESS (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1378/)
(Base Commit: f24a57f
<f24a57f>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14086 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p8bnh7N7sj-F0-mo7jaxnrpeVqChks5r47kkgaJpZM4NShCI>
.
|
|
@deads2k token_controller does:
e.secrets.Add(createdToken)
Can I simply port EtcdMutationCache upstream and replace this?
|
smarterclayton
force-pushed
the
secret_reuse
branch
from
a564213 to
913c0e1
Compare
smarterclayton
referenced
this pull request
May 12, 2017
smarterclayton
force-pushed
the
secret_reuse
branch
from
913c0e1 to
2e4c7bf
Compare
Yes |
|
Done
…On Fri, May 12, 2017 at 2:06 PM, David Eads ***@***.***> wrote:
Can I simply port EtcdMutationCache upstream and replace this?
Yes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14086 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pyrkM3kXysA7pxHLeOAdcdVFpnlRks5r5J-rgaJpZM4NShCI>
.
|
smarterclayton
force-pushed
the
secret_reuse
branch
4 times, most recently
from
63931d7 to
4473de2
Compare
|
[test] various weirdnesses |
|
@stevekuznetsov i can't figure out why test-go is reporting a failure.
|
smarterclayton
force-pushed
the
secret_reuse
branch
from
c0ff1d9 to
a068af6
Compare
openshift-bot
removed
the
needs-rebase
smarterclayton
force-pushed
the
secret_reuse
branch
from
a068af6 to
54c3db6
Compare
|
[test] |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
May 21, 2017
Automatic merge from submit-queue Move the remaining controllers to shared informers Completes work done in 1.6 to move the last two hold outs to shared informers - tokens controller and scheduler. Adds a few more tools to allow informer reuse (like filtering the informer, or maintaining a mutation cache). The mutation cache is identical to #45838 and will be removed when that merges @ncdc @deads2k extracted from openshift/origin#14086
|
[test] |
smarterclayton
force-pushed
the
secret_reuse
branch
from
54c3db6 to
d9fa993
Compare
|
[test]
…On Tue, May 23, 2017 at 9:29 PM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test Running (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1666/)
(Base Commit: 50b7254
<50b7254>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14086 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pyjBW0lNI9u6cergJb03qZK2CBe0ks5r84gPgaJpZM4NShCI>
.
|
|
Going to split into upstream stuff and downstream stuff. |
Ensure tests use unique names for clarity
smarterclayton
force-pushed
the
secret_reuse
branch
from
d9fa993 to
2695251
Compare
|
verbal lgtm from david, putting this in the queue to close the p0 memory regression in 3.6 [merge][severity: blocker] |
|
Evaluated for origin merge up to 2695251 |
|
[test] |
|
[test] boltdb panic |
|
Evaluated for origin test up to 2695251 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1761/) (Base Commit: 39be52c) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/811/) (Base Commit: 69de7d3) (Extended Tests: blocker) (Image: devenv-rhel7_6275) |
akhilerm
pushed a commit
to akhilerm/apimachinery
that referenced
this pull request
Sep 20, 2022
Automatic merge from submit-queue Move the remaining controllers to shared informers Completes work done in 1.6 to move the last two hold outs to shared informers - tokens controller and scheduler. Adds a few more tools to allow informer reuse (like filtering the informer, or maintaining a mutation cache). The mutation cache is identical to #45838 and will be removed when that merges @ncdc @deads2k extracted from openshift/origin#14086 Kubernetes-commit: 336fb2f508a62514a7d3744c46543db816277c3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate existing informers into shared informers.
The upstream token controller may need mutationcache
[test]