Force to specify not empty secret for metrics endpoint #13884
Conversation
| @@ -125,6 +125,9 @@ func Execute(configFile io.Reader) { | |||
|
|
|||
| // Registry extensions endpoint provides prometheus metrics. | |||
| if extraConfig.Metrics.Enabled { | |||
| if len(extraConfig.Metrics.Secret) == 0 { | |||
| context.GetLogger(app).Fatalf("secret token for metrics endpoint cannot be empty") | |||
There was a problem hiding this comment.
maybe specify the path like: the openshift.metrics.secret field cannot be empty when metrics are enabled
legionus
force-pushed
the
dockerregistry-metrics-not-empty-secret
branch
from
53b6cf9 to
1aae28d
Compare
|
@mfojtik done |
|
LGTM [merge] @smarterclayton FYI |
|
[Test]ing while waiting on the merge queue |
|
@legionus can you please rebase and then tag this again for merge? (1.6 rebase landed...) |
Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
legionus
force-pushed
the
dockerregistry-metrics-not-empty-secret
branch
from
1aae28d to
5914c45
Compare
|
[merge] |
|
Evaluated for origin test up to 5914c45 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1022/) (Base Commit: 87d6cb8) |
|
[merge] |
1 similar comment
|
[merge] |
|
[merge] #14122 |
|
Evaluated for origin merge up to 5914c45 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/597/) (Base Commit: 31caa0d) (Image: devenv-rhel7_6220) |
|
Can you change |
@mfojtik looks good ?