-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.3 Upstream patches for storage #10111
Conversation
[testextended][extended:core] |
@stevekuznetsov the bot would appear to be disobedient |
@pmorie the trigger no longer contains |
…space deletion" issue
[test] |
@pmorie FYI the |
yup, I asked for the normal test suite |
nodeName, | ||
err) | ||
return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return or continue? bigger question, should errors later in the loop return or continue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I need to consider this. We will need a new PR to fix it anyway, so this can go in and we'll do another patch PR later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up issue upstream is fine
LGTM, I await the great flake deliverance with great anticipation |
Evaluated for origin testextended up to ca7c590 |
[merge] |
Evaluated for origin test up to ca7c590 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7339/) (Image: devenv-rhel7_4718) |
Evaluated for origin merge up to ca7c590 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7339/) |
Green test run |
continuous-integration/openshift-jenkins/testextended FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/385/) (Extended Tests: core) |
Needed to fix issues with secret and configmap mounts timing out.
First level is upstream cherry-pick, second level is upstream master PRs: