Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Patch in our clients #9562

Closed
0xmichalis opened this issue Jun 25, 2016 · 8 comments
Closed

Add Patch in our clients #9562

0xmichalis opened this issue Jun 25, 2016 · 8 comments
Assignees

Comments

@0xmichalis
Copy link
Contributor

Currently added upstream in various pulls, this issue is for the work that needs to be done for our namespacers.

@deads2k @smarterclayton @mfojtik

@0xmichalis
Copy link
Contributor Author

0xmichalis commented Jun 25, 2016

kubernetes/kubernetes#27293 adds to clientset

@mfojtik
Copy link
Contributor

mfojtik commented Jun 29, 2016

@Kargakis dunno if this will be picked up with @smarterclayton rebase, but we just need to rerun the update-clientset script.

@mfojtik mfojtik self-assigned this Jun 29, 2016
@mfojtik
Copy link
Contributor

mfojtik commented Jun 29, 2016

(I will add Patch() to pkg/client/* as there are people using that package and we use it on many places already, but the long-term plan is to migrate to clientset)

@deads2k
Copy link
Contributor

deads2k commented Jun 29, 2016

I will add Patch() to pkg/client/*

I don't see a strong need, places that need it can lead the transition to clientsets.

Are you going to update for the rest of our objects and pull over the one-offs?

@mfojtik
Copy link
Contributor

mfojtik commented Jun 29, 2016

@deads2k yeah, more I'm digging into what everything will need update, more I'm inclined to simple transition to clientsets. Is the plan to switch pkg/client to use clientset entirely? (so in theory, I can just import github.com/openshift/origin/pkg/client and I have access to all resources. Or is this the uber-client scenario, we want to avoid?

@deads2k
Copy link
Contributor

deads2k commented Jun 29, 2016

Is the plan to switch pkg/client to use clientset entirely? (so in theory, I can just import github.com/openshift/origin/pkg/client and I have access to all resources. Or is this the uber-client scenario, we want to avoid?

We want to try, but we'll probably have to fix up the generator on our way through. Right now, "unusual" resources have to have hand-coded extension points wired in and if you're really unusual you have to write the entire thing yourself.

We've been enforcing the "use a namespacer" rule during reviews, so we've started subdividing already

@mfojtik
Copy link
Contributor

mfojtik commented Jun 29, 2016

@Kargakis we will start transition to cliensets for selected controllers after 3.3

@0xmichalis
Copy link
Contributor Author

@mfojtik fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants