Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UXP: Confusing or Unclear errors in 'oc describe' when mounting volumes - bubble up useful errors as events to be displayed #7902

Closed
screeley44 opened this issue Mar 9, 2016 · 4 comments
Assignees
Labels
component/storage lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/P2

Comments

@screeley44
Copy link
Contributor

As an example, if I'm submitting a pod with PV/PVC for GlusterFS and the endpoints are missing - a generic error is received: Error syncing pod, skipping: unsupported volume type

this error is misleading and the user is then left wondering/searching for the real cause, even something simple like in this case that the endpoints for the gluster cluster is missing or gone. I would like to add an event that shows up in the 'oc describe' where many users first go to analyze errors when something goes wrong. in most cases there is an error generated in the log with the real cause, but it's not surfaced easily to the user.

Example output from 'oc describe' would look like this for this particular example:

Events:
  FirstSeen LastSeen    Count   From            SubobjectPath   Type        Reason      Message
  --------- --------    -----   ----            -------------   --------    ------      -------
  12s       12s     1   {scheduler }                Normal      Scheduled   Successfully assigned bb-gluster-pod2 to k8dev.rhs
  12s       2s      2   {kubelet k8dev.rhs}         Warning     FailedMount Unable to mount volumes for pod "bb-gluster-pod2_default(a040fca7-e189-11e5-b936-52540092b5fb)": endpoints "glusterfs-cluster" not found

This would be accomplished by added useful error messages in the endpoint types (glusterfs.go, nfs.go, etc...) when needed and then setting them as an event using the kubelet event recorder like so:

kl.recorder.Eventf(ref, api.EventTypeWarning, kubecontainer.FailedMountVolume, "Unable to mount volumes for pod %q: %v", format.Pod(pod), err)

@smarterclayton @erinboyd @jeffvance - thoughts?

@screeley44
Copy link
Contributor Author

Created an issue upstream: kubernetes/kubernetes#22992

@screeley44
Copy link
Contributor Author

Created upstream k8 PR: kubernetes/kubernetes#23122

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 5, 2018
@0xmichalis
Copy link
Contributor

Seems fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/storage lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/P2
Projects
None yet
Development

No branches or pull requests

6 participants