Correct version comparisons to ensure proper fact evaluation #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user supplies the openshift_image_tag inventory fact as '3.5',
the evaluation of `version >= LooseVersion('3.5.0')` will return False.
Changing the evaluation against only the X.X release will properly
return True.
|
aos-ci-test |
|
[test] |
|
Flake openshift/origin#13067 oc new-app [It] should succeed with a --name of 58 characters |
|
Evaluated for openshift ansible test up to 6d4c84b |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/304/) (Base Commit: 2c03eec) (PR Branch Commit: 6d4c84b) |
sdodson
approved these changes
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user supplies the openshift_image_tag inventory fact as '3.5',
the evaluation of
version >= LooseVersion('3.5.0')will return False.Changing the evaluation against only the X.X release will properly
return True.
Bug https://bugzilla.redhat.com/show_bug.cgi?id=1466762