Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify matched openshift_upgrade_nodes_label #4498

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Verify matched openshift_upgrade_nodes_label #4498

merged 1 commit into from
Jun 22, 2017

Conversation

mtnbikenc
Copy link
Member

Verifies the provided label matches a set of hosts prior to upgrading.
If the label didn't match hosts, the upgrade would silently proceed with
upgrading all nodes given the logic for creating the oo_nodes_to_upgrade
group.

See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457914

@mtnbikenc
Verify matched openshift_upgrade_nodes_label
bf97562 
Verifies the provided label matches a set of hosts prior to upgrading.
If the label didn't match hosts, the upgrade would silently proceed with
upgrading all nodes given the logic for creating the oo_nodes_to_upgrade
group.
@mtnbikenc mtnbikenc self-assigned this Jun 19, 2017
@mtnbikenc mtnbikenc requested a review from dgoodwin June 19, 2017 19:35
@mtnbikenc
Copy link
Member Author

aos-ci-test

This was referenced Jun 19, 2017
Merged
Merged
@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for bf97562 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for bf97562 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for bf97562 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for bf97562 (logs)

dgoodwin
dgoodwin approved these changes Jun 20, 2017
View reviewed changes
Copy link
Contributor

@dgoodwin dgoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtnbikenc
Copy link
Member Author 

Failure summary:

  1. Host:     localhost
     Play:     Verify Requirements
     Task:     openshift_health_check
     Message:  One or more checks failed
     Details:  check "package_update":
               Could not perform a yum update.
               Errors from dependency resolution:
                 glibc-2.17-157.el7_3.2.i686 requires glibc-common = 2.17-157.el7_3.2
                 glibc-devel-2.17-157.el7_3.2.i686 requires glibc-headers = 2.17-157.el7_3.2
               You should resolve these issues before proceeding with an install.
               You may need to remove or downgrade packages or enable/disable yum repositories.

@rhcarvalho rhcarvalho mentioned this pull request Jun 21, 2017
Merged
@mtnbikenc
Copy link
Member Author

@sdodson this needs blocker merge from Project Committers because we don't have a CI flake referenced for the yum update issue.

@openshift openshift deleted a comment from rhcarvalho Jun 21, 2017
@openshift openshift deleted a comment from mtnbikenc Jun 21, 2017
@sdodson
Copy link
Member

sdodson commented Jun 21, 2017

[merge][severity: blocker]

1 similar comment
@sdodson
Copy link
Member

sdodson commented Jun 21, 2017

[merge][severity: blocker]

@sdodson
Copy link
Member

sdodson commented Jun 21, 2017

flake on openshift/origin#14043

@mtnbikenc
Copy link
Member Author

[merge][severity: blocker]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to bf97562

@sdodson
Copy link
Member

sdodson commented Jun 21, 2017 •
edited
Loading

I've reviewed the test logs and the upgrade worked so i'm fine with merging this manually if it fails. The only way this would cause test failures is if it completely skipped the node upgrade and that isn't happening.

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

@openshift-bot
Copy link

Evaluated for openshift ansible test up to bf97562

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/262/) (Base Commit: de93b27) (PR Branch Commit: bf97562)

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/617/) (Base Commit: 96756fe) (PR Branch Commit: bf97562) (Extended Tests: blocker)

@mtnbikenc
Copy link
Member Author

Flake openshift/origin#13271 Driver devicemapper failed
Flake openshift/origin#13067 oc new-app [It] should succeed with a --name of 58 characters

Also:

Failure talking to yum: File /var/cache/yum/x86_64/7Server/epel/metalink.xml does not exist

@sdodson sdodson merged commit ea79d8b into openshift:master Jun 22, 2017
@mtnbikenc mtnbikenc deleted the verify-upgrade-node-label branch June 22, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin dgoodwin approved these changes

Assignees

@mtnbikenc mtnbikenc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtnbikenc @openshift-bot @sdodson @dgoodwin