Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish etcd_common role #4124

Merged
merged 1 commit into from
May 10, 2017
Merged

polish etcd_common role #4124

merged 1 commit into from
May 10, 2017

Conversation

ingvagabund
Copy link
Member

  • remove unused etcdctl.sh file
  • update etcd_common README to capture the current offer of the role

@ingvagabund
Copy link
Member Author

@sdodson @ashcrow Yo, are there any other nits you can recall?

@ingvagabund ingvagabund requested review from sdodson and ashcrow May 9, 2017 11:57
@ingvagabund
Copy link
Member Author

aos-ci-test

@ingvagabund ingvagabund added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 9, 2017
sdodson
sdodson reviewed May 9, 2017
View reviewed changes
roles/etcd_common/README.md
- include_role:
name: etcd_common
tasks_from: etcdctl
```
Copy link
Member

@sdodson sdodson May 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of this mention of etcdctl in favor of the example playbook below? Just seems like duplication.

Copy link
Member Author

@ingvagabund ingvagabund May 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I have removed the first occurrence of the example in the description.

@ingvagabund ingvagabund mentioned this pull request May 9, 2017
Merged
@ingvagabund ingvagabund force-pushed the update-etcd-common-readme branch from a8c15e4 to f696358 Compare May 9, 2017 13:51
@ingvagabund
Copy link
Member Author

aos-ci-test

@openshift-bot
Copy link

error: aos-ci-jenkins/OS_3.6_containerized for a8c15e4 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for a8c15e4 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for a8c15e4 (logs)

@openshift-bot
Copy link

error: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for a8c15e4 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for f696358 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for f696358 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for f696358 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for f696358 (logs)

@ingvagabund
Copy link
Member Author

@sdodson PTAL

@sdodson
Copy link
Member

sdodson commented May 10, 2017

[merge]

@sdodson
Copy link
Member

sdodson commented May 10, 2017

flake openshift/origin#14122
[merge]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to f696358

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

@openshift-bot
Copy link

Evaluated for openshift ansible test up to f696358

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/107/) (Base Commit: 87c282b)

@openshift-bot
Copy link

openshift-bot commented May 10, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/349/) (Base Commit: c8e8f8f)

@openshift-bot openshift-bot merged commit 6e1f175 into openshift:master May 10, 2017
@ingvagabund ingvagabund deleted the update-etcd-common-readme branch May 11, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson sdodson left review comments

@ashcrow ashcrow Awaiting requested review from ashcrow

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ingvagabund @openshift-bot @sdodson