Remove vim configuration from Python files #4123
Conversation
In a project where contributors are free to use whatever editor they want and we have linting tools that verify the proper formatting of Python files, it should not be required to have a vim-specific line in Python files.
rhcarvalho
requested review from
tbielawa,
abutcher,
sdodson,
detiber and
mtnbikenc
|
FYI, We discussed and approved this in a prior arch call where we decided to forego the vim mode lines in favor of CI jobs that just enforced the rule which is already in place. |
|
aos-ci-test |
|
Thanks @sdodson |
|
bot, retest this please |
|
aos-ci-test |
|
|
|
[merge] |
|
re[merge] |
|
Evaluated for openshift ansible merge up to a0539d0 |
|
flake on openshift/origin#14122 |
|
continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/342/) (Base Commit: 5d408ee) |
|
Same flake / bug in the merge script -- openshift/origin#14122. This has passed all Ansible-based install tests and , should cover what we need to merge it. Merging it manually as per https://github.com/openshift/openshift-ansible/blob/master/docs/pull_requests.md#manual-merges. |
In a project where contributors are free to use whatever editor they want and we have linting tools that verify the proper formatting of Python files, it should not be required to have a vim-specific line in Python files.
The intention here is not to proclaim an editor war, but to pragmatically simplify the list of manual rules we want to enforce on contributors.
Inspired by code review in #3630 (comment).