bug 1430661. Update masterConfig metricsPublicURL on install #3625
Conversation
|
@sdodson @ewolinetz Should we cherry-pick to 1.5? |
|
Yes please. |
| modify_yaml: | ||
| dest: "{{ openshift.common.config_base }}/master/master-config.yaml" | ||
| yaml_key: assetConfig.metricsPublicURL | ||
| yaml_value: "https://{{ openshift_metrics_hawkular_hostname}}" |
There was a problem hiding this comment.
just to make sure, that variable doesn't already include "https://" correct?
There was a problem hiding this comment.
do we do that in logging? I did not see that.
|
This looks like it currently only updates for the master we are installing on, we want to make sure we also iterate over all the other masters as well and update their configs |
|
@ewolinetz is there example where we iterate masters to update configs? |
|
Seems like there should be some optimizations here as in if I'm installing both logging in metrics, there should be no need to bump the master server twice. |
|
@jcantrill thats the beauty of a handler, it should only run it once as long as its installing it from the same playbook edit: sauce - http://docs.ansible.com/ansible/playbooks_intro.html#handlers-running-operations-on-change |
|
aos-ci-test |
|
[merge] |
|
[test]ing while waiting on the merge queue |
|
Evaluated for openshift ansible test up to b70ccec |
|
b70ccec - State: success - All Test Contexts: aos-ci-jenkins/OS_unit_tests - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-2-unit-tests-1107/b70ccecac5ee1593754d4034c23feb58302e2bde.txt |
|
b70ccec - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.4_NOT_containerized, aos-ci-jenkins/OS_3.4_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.4,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-1111/b70ccecac5ee1593754d4034c23feb58302e2bde.txt |
|
b70ccec - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.5,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-1111/b70ccecac5ee1593754d4034c23feb58302e2bde.txt |
|
b70ccec - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.4_containerized, aos-ci-jenkins/OS_3.4_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.4,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-1111/b70ccecac5ee1593754d4034c23feb58302e2bde.txt |
|
b70ccec - State: success - All Test Contexts: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_containerized,OSE_VER=3.5,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster-containerized,TargetBranch=master,nodes=openshift-ansible-slave-1111/b70ccecac5ee1593754d4034c23feb58302e2bde.txt |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible_extended_conformance_install/17/) (Base Commit: 6ac067c) |
|
@openshift-bot, the last build failed from the following flakes: re[merge] |
|
Evaluated for openshift ansible merge up to b70ccec |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/23/) (Base Commit: 15100f2) |
No description provided.