Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: set diskStorageAccountType in aks e2e #5273

Merged
merged 1 commit into from
Dec 13, 2024
+5 −1
Merged

NO-JIRA: set diskStorageAccountType in aks e2e #5273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NO-JIRA: set diskStorageAccountType in aks e2e 
setting diskSotrageAccountType so that if the kube validation on the nodepool crd for this changes it will be caught in the e2e
  • Loading branch information
@Patryk-Stefanski
Patryk-Stefanski committed Dec 12, 2024
commit cd8717464fbcbbad4bc7984a127c313169c4f138
1 change: 1 addition & 0 deletions ...luster/azure/testdata/zz_fixture_TestCreateCluster_minimal_flags_necessary_to_render.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ spec:
type: ImageID
machineIdentityID: fakeMachineIdentityID
osDisk:
diskStorageAccountType: Premium_LRS
sizeGiB: 120
subnetID: fakeSubnetID
vmSize: Standard_D4s_v3
Expand Down
2 changes: 2 additions & 0 deletions cmd/cluster/azure/testdata/zz_fixture_TestCreateCluster_with_availability_ones.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ spec:
type: ImageID
machineIdentityID: fakeMachineIdentityID
osDisk:
diskStorageAccountType: Premium_LRS
sizeGiB: 120
subnetID: fakeSubnetID
vmSize: Standard_D4s_v3
Expand Down Expand Up @@ -193,6 +194,7 @@ spec:
type: ImageID
machineIdentityID: fakeMachineIdentityID
osDisk:
diskStorageAccountType: Premium_LRS
sizeGiB: 120
subnetID: fakeSubnetID
vmSize: Standard_D4s_v3
Expand Down
3 changes: 2 additions & 1 deletion cmd/nodepool/azure/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ type RawAzurePlatformCreateOptions struct {
func DefaultOptions() *RawAzurePlatformCreateOptions {
return &RawAzurePlatformCreateOptions{
AzurePlatformCreateOptions: &AzurePlatformCreateOptions{
DiskSize: 120,
DiskSize: 120,
DiskStorageAccountType: string(hyperv1.DiskStorageAccountTypesPremiumLRS),
},
AzureMarketPlaceImageInfo: &AzureMarketPlaceImageInfo{},
}
Expand Down