Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-44927: Add multi-arch validation for HC/NodePool compatibility #5238

Open
wants to merge 9 commits into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-44927: Add multi-arch validation for HC/NodePool compatibility #5238

wants to merge 9 commits into from

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Dec 5, 2024 •
edited
Loading

What this PR does / why we need it:
This is a manual backport of

Some notes...
I did not backport this specific commit since it was an upstreams doc commit - 7092f44.

There's an extra commit on this PR, which is the last commit. It was the run make update commit since some of the API go.mod libraries were bumped in the original PR that are not in 4.17.

Which issue(s) this PR fixes:
Fixes OCPBUGS-44927

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2024
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-44927, which is invalid:

  • expected the bug to target the "4.17.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-44927 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
This is a manual backport of

Which issue(s) this PR fixes:
Fixes OCPBUGS-44927

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI labels Dec 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Dec 5, 2024
@bryan-cox
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-44927, which is invalid:

  • expected Jira Issue OCPBUGS-44927 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2024
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-44927, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-45653 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-45653 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/retest

for konflux

@openshift-ci openshift-ci bot requested a review from LiangquanLi930 December 5, 2024 13:45
@openshift-ci-robot
Copy link

@bryan-cox: This pull request references Jira Issue OCPBUGS-44927, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-45653 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-45653 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

What this PR does / why we need it:
This is a manual backport of

Some notes...
I did not backport this specific commit since it was an upstreams doc commit - 7092f44.

There's an extra commit on this PR, which is the last commit. It was the run make update commit since some of the API go.mod libraries were bumped in the original PR that are not in 4.17.

Which issue(s) this PR fixes:
Fixes OCPBUGS-44927

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member Author

/retest

2 similar comments
@bryan-cox
Copy link
Member Author

/retest

@jparrill
Copy link
Contributor

/retest

@jparrill
Copy link
Contributor

Hey @bryan-cox I think this and the above bugs need the Release Note thing.

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Validate multi-arch image/stream for all platforms
b7b7ded 
This commit refactors the multi-arch release image/stream validation
into the core CLI since Agent, AWS, and Azure are capable of
multi-arch HostedClusters.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Add PayloadArch field to HostedCluster Status
ecbf3cd 
Add PayloadArch field to HostedCluster Status track the CPU
architecture of the HostedCluster release image. This information
informs if the HostedCluster is multi-arch capable or not.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Validate NP CPU arch is supported by HC payload
3b34637 
Validate the NodePool's CPU architecture can be supported by the
HostedCluster's release image payload.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Create function to retrieve the pull secret bytes
6365fdb 
Create a function to retrieve the pull secret bytes from a HostedCluster

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Deprecate MultiArch API field and CLI flag
62cc83f 
Deprecate MultiArch API field and CLI flag. Multi-arch validation is now
 automatically performed based on the release image.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Add CPU check in AWS & Azure NP Create CLI command
24d691c 
Add a NodePool CPU check in the Azure and AWS NodePool Create CLI
commands. This check will make sure the HostedCluster payload arch
supports the NodePool CPU architecture.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Add ArchitectureMulti to NodePool API
306800a 
This commit:
- adds ArchitectureMulti to NodePool API so we are comparing to `multi`
consistently in our codebase.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Validate PayloadArch set correctly in e2e
4d751cc 
Validates HostedCluster.Status.PayloadArch is set correctly in e2e.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Run make update
bddbc29
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Member Author

/retest

1 similar comment
@LiangquanLi930
Copy link
Member

/retest

@LiangquanLi930
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

@LiangquanLi930 LiangquanLi930 Awaiting requested review from LiangquanLi930

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bryan-cox @openshift-ci-robot @jparrill @LiangquanLi930