OCPBUGS-44960: (OSASINFRA-3643) bump k8s and dependencies #4927

EmilienM · 2024-10-16T17:37:32Z

Changes in go.mod:

Use github.com/distribution/reference
Bump github.com/openshift/api and client-go to latest
Bump github.com/openshift/library-go to latest
Bump github.com/prometheus/common to v0.55.0
Bump k8s and deps to v0.31.1
Bump CAPI to v1.8.5
Bump sigs.k8s.io/controller-runtime to v0.19.0

Then code changes to adjust with the new versions.

openshift-ci-robot · 2024-10-16T17:37:37Z

@EmilienM: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:

[vendoring] bump k8s and o/api

Update controllers for new controller-runtime

bump o/library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-16T17:51:52Z

@EmilienM: This pull request references Jira Issue OCPBUGS-43459, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

[vendoring] bump k8s and o/api

Update controllers for new controller-runtime

bump o/library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

EmilienM · 2024-10-16T17:52:24Z

/jira refresh

openshift-ci-robot · 2024-10-16T17:52:30Z

@EmilienM: This pull request references Jira Issue OCPBUGS-43459, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-16T20:17:51Z

@EmilienM: This pull request references Jira Issue OCPBUGS-43459, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (emacchi@redhat.com), skipping review request.

In response to this:

Changes in go.mod:

Use github.com/distribution/reference

Bump github.com/openshift/api to latest

Bump github.com/openshift/library-go to latest

Bump github.com/prometheus/common to v0.55.0

Bump k8s and deps to v0.31.1

Bump CAPI to v1.8.4

Bump sigs.k8s.io/controller-runtime to v0.19.0

Then code changes to adjust with the new versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

enxebre · 2024-10-17T07:02:47Z

/hold
Thanks! Lets wait for #4927 to merge before proceeding here

EmilienM · 2024-10-17T14:42:11Z

/hold cancel

jparrill · 2024-11-20T14:11:21Z

/test e2e-aws

enxebre · 2024-11-20T16:13:55Z

...edcontrolplane/testdata/openshift-oauth-apiserver/zz_fixture_TestControlPlaneComponents.yaml

@@ -29,7 +29,7 @@ spec:
    metadata:
      annotations:
        cluster-autoscaler.kubernetes.io/safe-to-evict-local-volumes: work-logs
-        component.hypershift.openshift.io/config-hash: 19dc307e3415eb66


Why is this changing? does this mean this would cause a fleet wide rollout of this components?

EmilienM · 2024-11-20T21:26:56Z

I'll squash the third commit into the first if that passes verify and unit jobs.
Note that this PR is purely a rebase on main.

EmilienM · 2024-11-21T12:54:59Z

/test e2e-aws
a timeout
/test e2e-aks

EmilienM · 2024-11-22T01:55:23Z

/retest-required

Patryk-Stefanski · 2024-11-25T15:48:14Z

/retitle OCPBUGS-44960: (OSASINFRA-3643) bump k8s and dependencies

openshift-ci-robot · 2024-11-25T15:48:23Z

@EmilienM: This pull request references Jira Issue OCPBUGS-44960, which is invalid:

expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Changes in go.mod:

Use github.com/distribution/reference

Bump github.com/openshift/api and client-go to latest

Bump github.com/openshift/library-go to latest

Bump github.com/prometheus/common to v0.55.0

Bump k8s and deps to v0.31.1

Bump CAPI to v1.8.5

Bump sigs.k8s.io/controller-runtime to v0.19.0

Then code changes to adjust with the new versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

EmilienM · 2024-11-25T16:27:17Z

/jira refresh

openshift-ci-robot · 2024-11-25T16:27:23Z

@EmilienM: This pull request references Jira Issue OCPBUGS-44960, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

EmilienM · 2024-11-26T16:51:30Z

/retest-required

EmilienM · 2024-12-02T15:18:09Z

/retest-required

EmilienM · 2024-12-09T17:36:34Z

/test e2e-aws

EmilienM · 2024-12-11T16:29:50Z

failed to dump hosted cluster: found WARNING: Object got updated more than one time without a no-op update, this indicates hypershift incorrectly reverting defaulted values messages in file /logs/artifacts/TestCreateCluster/namespaces/e2e-clusters-nkqbf-example-7v4mv/core/pods/logs/hosted-cluster-config-operator-59f444bbc-xgqzc-hosted-cluster-config-operator.log

And again we have this error:

  &v1.Infrastructure{
  	TypeMeta:   {Kind: "Infrastructure", APIVersion: "config.openshift.io/v1"},
  	ObjectMeta: {Name: "cluster", UID: "4a4263a5-cbbb-4fa1-868b-cf2351bf675a", ResourceVersion: "1502", Generation: 2, ...},
  	Spec:       {PlatformSpec: {Type: "AWS", AWS: &{}}},
  	Status: v1.InfrastructureStatus{
  		InfrastructureName: "example-7v4mv",
  		Platform:           "AWS",
  		PlatformStatus: &v1.PlatformStatus{
  			Type: "AWS",
  			AWS: &v1.AWSPlatformStatus{
  				Region:                  "us-east-1",
  				ServiceEndpoints:        nil,
  				ResourceTags:            {{Key: "expirationDate", Value: "2024-12-09T22:26+00:00"}},
- 				CloudLoadBalancerConfig: &v1.CloudLoadBalancerConfig{DNSType: "PlatformDefault"},
+ 				CloudLoadBalancerConfig: nil,
  			},
  			Azure: nil,
  			GCP:   nil,
  			... // 11 identical fields
  		},
  		EtcdDiscoveryDomain: "example-7v4mv.ci.hypershift.devcluster.openshift.com",
  		APIServerURL:        "https://api-example-7v4mv.service.ci.hypershift.devcluster.opens"...,
  		... // 4 identical fields
  	},
  }

I thought we fixed that in support/globalconfig/infrastructure.go.
I'll look at it again.

* Ignition to 2.18.0 * openshift/api and client-go to the most recent commit on November 18th 2024. * k8s to v0.31.1 * CAPI to v1.8.4 * controller-runtime to v0.19.0 And then run `go mod tidy && go mod vendor`, `make update` and `UPDATE=true go test ./...`.

openshift-ci · 2024-12-11T17:08:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-12-16T23:20:27Z

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-kubevirt-azure-ovn	`411f2e4`	link	false	`/test e2e-kubevirt-azure-ovn`
ci/prow/e2e-openstack	`411f2e4`	link	false	`/test e2e-openstack`
ci/prow/e2e-aws-4-17	`0401e03`	link	true	`/test e2e-aws-4-17`
ci/prow/okd-scos-e2e-aws-ovn	`9776192`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-override	`9776192`	link	true	`/test e2e-aws-override`
ci/prow/e2e-aws	`9776192`	link	true	`/test e2e-aws`
ci/prow/e2e-kubevirt-aws-ovn-reduced	`9776192`	link	true	`/test e2e-kubevirt-aws-ovn-reduced`
ci/prow/e2e-aws-upgrade-hypershift-operator	`9776192`	link	true	`/test e2e-aws-upgrade-hypershift-operator`
ci/prow/unit	`9776192`	link	true	`/test unit`
ci/prow/e2e-aks	`9776192`	link	true	`/test e2e-aks`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 16, 2024

openshift-ci bot added the do-not-merge/needs-area label Oct 16, 2024

openshift-ci bot requested review from isco-rodriguez and sjenning October 16, 2024 17:38

EmilienM force-pushed the k131 branch from aed37bb to ddbfddf Compare October 16, 2024 17:47

EmilienM changed the title ~~NO-JIRA: bump k8s and dependencies~~ OCPBUGS-43459: bump k8s and dependencies Oct 16, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 16, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 16, 2024

EmilienM force-pushed the k131 branch from dafb5b2 to 98b53c7 Compare October 16, 2024 18:11

openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI labels Oct 16, 2024

EmilienM force-pushed the k131 branch from 4daa49e to 58d8b6d Compare October 16, 2024 20:17

EmilienM force-pushed the k131 branch 3 times, most recently from 8b71b0b to 41be629 Compare October 16, 2024 20:26

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2024

EmilienM force-pushed the k131 branch from 41be629 to 6ee6581 Compare October 17, 2024 14:41

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2024

enxebre reviewed Nov 20, 2024

View reviewed changes

EmilienM force-pushed the k131 branch from 524b84f to 83a578e Compare November 20, 2024 20:49

EmilienM force-pushed the k131 branch from 83a578e to a39abfc Compare November 21, 2024 02:51

openshift-ci bot changed the title ~~OSASINFRA-3643: bump k8s and dependencies~~ OCPBUGS-44960: (OSASINFRA-3643) bump k8s and dependencies Nov 25, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 25, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024

EmilienM force-pushed the k131 branch from a39abfc to 0401e03 Compare November 25, 2024 15:53

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 25, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 25, 2024

EmilienM force-pushed the k131 branch 3 times, most recently from 77450c0 to 0903b33 Compare December 9, 2024 15:08

EmilienM added 2 commits December 11, 2024 11:30

Update CPO, HO and support for new dependencies

9776192

EmilienM force-pushed the k131 branch from 0903b33 to 9776192 Compare December 11, 2024 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-44960: (OSASINFRA-3643) bump k8s and dependencies #4927

OCPBUGS-44960: (OSASINFRA-3643) bump k8s and dependencies #4927

EmilienM commented Oct 16, 2024 •

edited

Loading

openshift-ci-robot commented Oct 16, 2024

openshift-ci-robot commented Oct 16, 2024

EmilienM commented Oct 16, 2024

openshift-ci-robot commented Oct 16, 2024

openshift-ci-robot commented Oct 16, 2024

enxebre commented Oct 17, 2024

EmilienM commented Oct 17, 2024

jparrill commented Nov 20, 2024

enxebre Nov 20, 2024

EmilienM commented Nov 20, 2024

EmilienM commented Nov 21, 2024

EmilienM commented Nov 22, 2024

Patryk-Stefanski commented Nov 25, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 25, 2024

EmilienM commented Nov 25, 2024

openshift-ci-robot commented Nov 25, 2024

EmilienM commented Nov 26, 2024

EmilienM commented Dec 2, 2024

EmilienM commented Dec 9, 2024

EmilienM commented Dec 11, 2024

openshift-ci bot commented Dec 11, 2024

openshift-ci bot commented Dec 16, 2024

OCPBUGS-44960: (OSASINFRA-3643) bump k8s and dependencies #4927

Are you sure you want to change the base?

OCPBUGS-44960: (OSASINFRA-3643) bump k8s and dependencies #4927

Conversation

EmilienM commented Oct 16, 2024 • edited Loading

openshift-ci-robot commented Oct 16, 2024

openshift-ci-robot commented Oct 16, 2024

EmilienM commented Oct 16, 2024

openshift-ci-robot commented Oct 16, 2024

openshift-ci-robot commented Oct 16, 2024

enxebre commented Oct 17, 2024

EmilienM commented Oct 17, 2024

jparrill commented Nov 20, 2024

enxebre Nov 20, 2024

Choose a reason for hiding this comment

EmilienM commented Nov 20, 2024

EmilienM commented Nov 21, 2024

EmilienM commented Nov 22, 2024

Patryk-Stefanski commented Nov 25, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Nov 25, 2024

EmilienM commented Nov 25, 2024

openshift-ci-robot commented Nov 25, 2024

EmilienM commented Nov 26, 2024

EmilienM commented Dec 2, 2024

EmilienM commented Dec 9, 2024

EmilienM commented Dec 11, 2024

openshift-ci bot commented Dec 11, 2024

openshift-ci bot commented Dec 16, 2024

EmilienM commented Oct 16, 2024 •

edited

Loading

Patryk-Stefanski commented Nov 25, 2024 •

edited by openshift-ci bot

Loading