Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile SecretProvider for CNCC on ARO HCP #4903

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Adds fields in the Azure HostedCluster API for the managed identities
used for the following control plane components: azure cloud provider,
KMS, CAPZ, the control plane operator, the image registry operator,
cluster ingress operator, cluster network
operator/cluster-network-config-controller, azure-disk-controller and
 azure-file-controller.

This commit also adds fields for the management cluster's Azure key
vault where the managed identity certificates are stored.

Signed-off-by: Bryan Cox <brcox@redhat.com>
Add generic create function for SecretProviderClass for ARO HCP.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2024
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Oct 11, 2024
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 01c1c1b
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/67095b09426b9c0008531e9a
😎 Deploy Preview https://deploy-preview-4903--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bryan-cox bryan-cox force-pushed the aro-hcp-cno-cert branch 2 times, most recently from 11be7a7 to 061992f Compare October 11, 2024 17:10
Reconcile the SecretProviderClass for the cloud network config
controller (CNCC) for ARO HCP deployments. The SecretProviderClass is
used by the Secrets Store CSI driver to mount a certificate to a volume
in the CNCC pod deployment.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox bryan-cox changed the title Aro hcp cno cert Reconcile SecretProvider for CNCC on ARO HCP Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant