Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43064: move resource.k8s.io to v1alpha3 for kube 1.31 #4887

Merged
merged 1 commit into from
Oct 11, 2024
Merged

OCPBUGS-43064: move resource.k8s.io to v1alpha3 for kube 1.31 #4887

merged 1 commit into from
Oct 11, 2024

Conversation

sjenning
Copy link
Contributor

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release labels Oct 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Oct 10, 2024
@sjenning sjenning changed the title move resource.k8s.io to v1alpha3 for kube 1.31 OCPBUGS-43064: move resource.k8s.io to v1alpha3 for kube 1.31 Oct 10, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 10, 2024
@openshift-ci-robot
Copy link

@sjenning: This pull request references Jira Issue OCPBUGS-43064, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

KASO did this here
https://github.com/openshift/cluster-kube-apiserver-operator/pull/1731/files#diff-1460721532208bb105e22ac02386e5e51a23c597dac5ab57ba59592a0e0eef1bR22-R25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjenning sjenning marked this pull request as ready for review October 10, 2024 19:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024
@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a0191db and 2 for PR HEAD d3a9400 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 03907a6 into main Oct 11, 2024
14 checks passed
@openshift-ci-robot
Copy link

@sjenning: Jira Issue OCPBUGS-43064: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-43064 has not been moved to the MODIFIED state.

In response to this:

KASO did this here
https://github.com/openshift/cluster-kube-apiserver-operator/pull/1731/files#diff-1460721532208bb105e22ac02386e5e51a23c597dac5ab57ba59592a0e0eef1bR22-R25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjenning sjenning mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjenning @openshift-ci-robot @bryan-cox