Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43087: openstack/e2e: re-work nodepool tests #4868

Merged
merged 1 commit into from
Oct 15, 2024
Merged

OCPBUGS-43087: openstack/e2e: re-work nodepool tests #4868

merged 1 commit into from
Oct 15, 2024
+40 −17

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Oct 9, 2024 •
edited
Loading

  • When running the nodepool tests, the HostedCluster is created with a
    initial Nodepool and a replica == 0. That involves that the
    router-default won't exist and therefore we can't expect the Ingress to
    work. So let's skip the DNS record creation when there is no nodepool
    but show a warning because we can't expect the cluster to be healthy.

  • Remove double get guestClient when creating Route54 records.

  • nodepool: force replica to 1 for the default since we need one
    nodepool for Ingress to be working.

  • Use an existing function to test the Nodepool replicas and the nodes
    numbers.

  • skip NTO tests which can't work on the OpenStack platform at this
    time.

  • nodepool/openstack: support AMD64 arch.

  • nodepool/openstack: add missing watch in the reconciler.

@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label Oct 9, 2024
@EmilienM
Copy link
Member Author

EmilienM commented Oct 9, 2024

/test e2e-openstack-nfv

@EmilienM
Copy link
Member Author

EmilienM commented Oct 9, 2024

/test e2e-openstack-nfv

@EmilienM EmilienM mentioned this pull request Oct 9, 2024
Merged
@EmilienM
Copy link
Member Author

EmilienM commented Oct 9, 2024

/test e2e-openstack-nodepools

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

@EmilienM: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aks
  • /test e2e-aws
  • /test e2e-aws-4-17
  • /test e2e-kubevirt-aws-ovn-reduced
  • /test images
  • /test security
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-metrics
  • /test e2e-azure-aks-ovn-conformance
  • /test e2e-conformance
  • /test e2e-kubevirt-aws-ovn
  • /test e2e-kubevirt-azure-ovn
  • /test e2e-kubevirt-metal-conformance
  • /test e2e-openstack
  • /test e2e-openstack-nfv
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aks
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-aws-4-17
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-security
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/test e2e-openstack-nodepools

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM
Copy link
Member Author

EmilienM commented Oct 9, 2024

/test e2e-openstack-nodepools

1 similar comment
@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024 •
edited
Loading

@EmilienM: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv 3734a4e link false /test e2e-openstack-nfv

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Oct 10, 2024
@EmilienM EmilienM changed the title openstack/e2e: don't create ingress record if no nodepool openstack/e2e: re-work nodepool tests Oct 10, 2024
@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

1 similar comment
@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@jparrill
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 11, 2024
@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-43087, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • When running the nodepool tests, the HostedCluster is created with a
    initial Nodepool and a replica == 0. That involves that the
    router-default won't exist and therefore we can't expect the Ingress to
    work. So let's skip the DNS record creation when there is no nodepool
    but show a warning because we can't expect the cluster to be healthy.

  • Remove double get guestClient when creating Route54 records.

  • nodepool: force replica to 1 for the default since we need one
    nodepool for Ingress to be working.

  • Use an existing function to test the Nodepool replicas and the nodes
    numbers.

  • skip NTO tests which can't work on the OpenStack platform at this
    time.

  • nodepool/openstack: support AMD64 arch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2024
@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-43087, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Member Author

/cc csrwng

@openshift-ci openshift-ci bot requested a review from csrwng October 11, 2024 11:36
@EmilienM
Copy link
Member Author

CI results: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/4868/pull-ci-openshift-hypershift-main-e2e-openstack-nodepools/1844464816853356544

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-43087, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

  • When running the nodepool tests, the HostedCluster is created with a
    initial Nodepool and a replica == 0. That involves that the
    router-default won't exist and therefore we can't expect the Ingress to
    work. So let's skip the DNS record creation when there is no nodepool
    but show a warning because we can't expect the cluster to be healthy.

  • Remove double get guestClient when creating Route54 records.

  • nodepool: force replica to 1 for the default since we need one
    nodepool for Ingress to be working.

  • Use an existing function to test the Nodepool replicas and the nodes
    numbers.

  • skip NTO tests which can't work on the OpenStack platform at this
    time.

  • nodepool/openstack: support AMD64 arch.

  • nodepool/openstack: add missing watch in the reconciler.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@EmilienM
openstack/e2e: re-work nodepool tests
d06c89d 
* When running the nodepool tests, the HostedCluster is created with a
  initial Nodepool and a replica == 0. That involves that the
  router-default won't exist and therefore we can't expect the Ingress to
  work. So let's skip the DNS record creation when there is no nodepool
  but show a warning because we can't expect the cluster to be healthy.

* Remove double get guestClient when creating Route54 records.

* nodepool: force replica to 1 for the default since we need one
  nodepool for Ingress to be working.

* Use an existing function to test the Nodepool replicas and the nodes
  numbers.

* skip NTO tests which can't work on the OpenStack platform at this
  time.

* nodepool/openstack: support AMD64 arch.

* nodepool/openstack: add missing watch in the reconciler
@EmilienM
Copy link
Member Author

/test e2e-openstack-nodepools

@EmilienM
Copy link
Member Author

/retest

jparrill

This comment was marked as duplicate.

Sign in to view

jparrill
jparrill reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
@enxebre
Copy link
Member

enxebre commented Oct 15, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e2f9c02 into openshift:main Oct 15, 2024
16 checks passed
@openshift-ci-robot
Copy link

@EmilienM: Jira Issue OCPBUGS-43087: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43087 has been moved to the MODIFIED state.

In response to this:

  • When running the nodepool tests, the HostedCluster is created with a
    initial Nodepool and a replica == 0. That involves that the
    router-default won't exist and therefore we can't expect the Ingress to
    work. So let's skip the DNS record creation when there is no nodepool
    but show a warning because we can't expect the cluster to be healthy.

  • Remove double get guestClient when creating Route54 records.

  • nodepool: force replica to 1 for the default since we need one
    nodepool for Ingress to be working.

  • Use an existing function to test the Nodepool replicas and the nodes
    numbers.

  • skip NTO tests which can't work on the OpenStack platform at this
    time.

  • nodepool/openstack: support AMD64 arch.

  • nodepool/openstack: add missing watch in the reconciler.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM EmilienM deleted the osp_np_e2e branch October 15, 2024 15:07
@EmilienM
Copy link
Member Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@EmilienM: #4868 failed to apply on top of branch "release-4.17":

Applying: openstack/e2e: re-work nodepool tests
Using index info to reconstruct a base tree...
A	hypershift-operator/controllers/nodepool/capi.go
M	hypershift-operator/controllers/nodepool/nodepool_controller.go
M	test/e2e/nodepool_machineconfig_test.go
M	test/e2e/nodepool_nto_performanceprofile_test.go
M	test/e2e/nodepool_test.go
M	test/e2e/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/util/util.go
Auto-merging test/e2e/nodepool_test.go
Auto-merging test/e2e/nodepool_nto_performanceprofile_test.go
Auto-merging test/e2e/nodepool_machineconfig_test.go
Auto-merging hypershift-operator/controllers/nodepool/nodepool_controller.go
CONFLICT (modify/delete): hypershift-operator/controllers/nodepool/capi.go deleted in HEAD and modified in openstack/e2e: re-work nodepool tests. Version openstack/e2e: re-work nodepool tests of hypershift-operator/controllers/nodepool/capi.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 openstack/e2e: re-work nodepool tests

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM EmilienM mentioned this pull request Oct 15, 2024
Open
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202410151810.p0.ge2f9c02.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparrill jparrill jparrill left review comments

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@jparrill jparrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EmilienM @jparrill @openshift-ci-robot @enxebre @openshift-cherrypick-robot @openshift-bot