Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document KubeVirt platform live migration expectations #4862

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidvossel
Copy link
Contributor

This adds documentation that outlines the expectations around KubeVirt VM live migration within hypershift

Signed-off-by: David Vossel <davidvossel@gmail.com>
@openshift-ci openshift-ci bot requested review from csrwng and hasueki October 8, 2024 18:34
@openshift-ci openshift-ci bot added the area/documentation Indicates the PR includes changes for documentation label Oct 8, 2024
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit d35d8da
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/670599b85ede110008452265
😎 Deploy Preview https://deploy-preview-4862--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
Signed-off-by: David Vossel <davidvossel@gmail.com>
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@davidvossel: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David, just small nit.

@@ -0,0 +1,64 @@
# Worker Node Live Migration Overview

In order to prevent disrupting guest cluster workloads, guest cluster VMs are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/guest/hosted/

the underlying infrastructure cluster hosting the VMs.

This functionality allows the underlying infrastructure cluster to update
without impacting the availability and operation of the KubeVirt platform guest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/guest/hosted/

## Expections when Live Migration is Disabled

When VMs within a NodePool are not capable of live migrating, workload
disruption on the guest cluster can occur during infrastructure cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/guest/hosted/

disruption on the guest cluster can occur during infrastructure cluster
maintenance events. By default during normal operation the hypershift
controllers will attempt to drain the workloads hosted on KubeVirt VMs not
capable of live migration before the VM is shutdown. Draining the guest cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/guest/hosted/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants