-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document KubeVirt platform live migration expectations #4862
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: David Vossel <davidvossel@gmail.com>
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidvossel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: David Vossel <davidvossel@gmail.com>
@davidvossel: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks David, just small nit.
@@ -0,0 +1,64 @@ | |||
# Worker Node Live Migration Overview | |||
|
|||
In order to prevent disrupting guest cluster workloads, guest cluster VMs are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/guest/hosted/
the underlying infrastructure cluster hosting the VMs. | ||
|
||
This functionality allows the underlying infrastructure cluster to update | ||
without impacting the availability and operation of the KubeVirt platform guest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/guest/hosted/
## Expections when Live Migration is Disabled | ||
|
||
When VMs within a NodePool are not capable of live migrating, workload | ||
disruption on the guest cluster can occur during infrastructure cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/guest/hosted/
disruption on the guest cluster can occur during infrastructure cluster | ||
maintenance events. By default during normal operation the hypershift | ||
controllers will attempt to drain the workloads hosted on KubeVirt VMs not | ||
capable of live migration before the VM is shutdown. Draining the guest cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/guest/hosted/
This adds documentation that outlines the expectations around KubeVirt VM live migration within hypershift