Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1542: Implement Workload Identity in Azure for Data Plane Components Part 3 #4587

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

HOSTEDCP-1542: Implement Workload Identity in Azure for Data Plane Components Part 3 #4587

wants to merge 4 commits into from

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented Aug 21, 2024 •
edited
Loading

What this PR does / why we need it:
This PR is part 3 of implementing workload identity for Azure HCP for data plane components. Specifically this PR only includes changes to the HO & docs.

The PR for part 4 is - #5361.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1542

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 21, 2024 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 21, 2024 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 21, 2024 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Aug 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Aug 21, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 21, 2024 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 3a832f2
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6733ae044e45c50008ae0eec
😎 Deploy Preview https://deploy-preview-4587--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2024 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1542

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2024
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1542 branch 5 times, most recently from 8ff8ad3 to 588c678 Compare August 30, 2024 17:22
@openshift-ci openshift-ci bot added the area/api Indicates the PR includes changes for the API label Nov 6, 2024
@bryan-cox bryan-cox force-pushed the HOSTEDCP-1542 branch 4 times, most recently from fcf4e21 to c492543 Compare November 11, 2024 22:17
@bryan-cox
Copy link
Member Author

/hold

Needs:

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-1542 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

What this PR does / why we need it:
This PR is part 3 of implementing workload identity for Azure HCP for data plane components. Specifically this PR only includes changes to the HO & docs.

The PR for part 4 is - #5361.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1542

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox marked this pull request as ready for review January 9, 2025 22:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2025
@openshift-ci openshift-ci bot requested a review from sjenning January 9, 2025 22:23
@bryan-cox bryan-cox changed the title HOSTEDCP-1542: Implement Workload Identity in Azure for Data Plane Components Part 1 HOSTEDCP-1542: Implement Workload Identity in Azure for Data Plane Components Part 3 Jan 10, 2025
@bryan-cox
Add data plane MIs to the Azure HostedCluster API
18a80a7 
Add MSI client IDs related to the data plane to the Azure HostedCluster
API for image registry, azure file CSI driver, and azure disk CSI driver
.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Add flags in Azure cluster create CLI for WI
883130f 
This commit adds flags in the Azure cluster create CLI to support
workload identity as the authentication type. Flags added allow the MSI
client IDs to be passed in on creation as well as the issuer URL and
service account token issue private key.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Update contrib docs for workload identity
4c1a7ea 
This commit updates some contrib documents related to workload identity
to include the latest instructions for setting up workload identity.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Enable Workload Identity e2e flags
40d699f 
This commit enables the workload identity e2e flags

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/test e2e-aks

@bryan-cox
Copy link
Member Author

/hold cancel

All prerequisite PRs are merged now.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@bryan-cox
Copy link
Member Author

/retest-required

@Patryk-Stefanski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8bb9160 and 2 for PR HEAD 40d699f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7c9455f and 2 for PR HEAD 40d699f in total

@bryan-cox
Copy link
Member Author

/retest-required

@bryan-cox
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 36db419 and 1 for PR HEAD 40d699f in total

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/test images

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 36db419 and 2 for PR HEAD 40d699f in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-4-17 588c678 link true /test e2e-aws-4-17
ci/prow/e2e-aws-4-18 40d699f link true /test e2e-aws-4-18
ci/prow/e2e-aks 40d699f link true /test e2e-aks
ci/prow/e2e-aws-upgrade-hypershift-operator 40d699f link true /test e2e-aws-upgrade-hypershift-operator
ci/prow/images 40d699f link true /test images
ci/prow/e2e-kubevirt-aws-ovn-reduced 40d699f link true /test e2e-kubevirt-aws-ovn-reduced
ci/prow/e2e-aws 40d699f link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@Patryk-Stefanski Patryk-Stefanski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bryan-cox @openshift-ci-robot @Patryk-Stefanski @sjenning @openshift-merge-robot