Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1709: hack/test: remove timeouts #4169

Merged
merged 1 commit into from
Jun 7, 2024
Merged

HOSTEDCP-1709: hack/test: remove timeouts #4169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
hack/test: remove timeouts 
The top-level `go test` timeout does nothing beneficial for us - we need
to be well-formed in the face of SIGTERM from the test platform anyway,
and we need to time out within our tests, not from the top-level, as
this will give us sensible test failure output (e.g. a specific
assertion failed) versus the current panic output which makes it
impossible to generate jUnit.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
  • Loading branch information
@stevekuznetsov
stevekuznetsov committed Jun 6, 2024
commit 7688ecfae0ca822dc581f061c015fa640dbe23ef
1 change: 0 additions & 1 deletion hack/ci-test-e2e-azure.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ trap generate_junit EXIT

bin/test-e2e \
-test.v \
-test.timeout=2h10m \
-test.run='^TestCreateCluster.*|^TestNodePool.*' \
-test.parallel=20 \
--e2e.platform=Azure \
Expand Down
1 change: 0 additions & 1 deletion hack/ci-test-e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ fi

bin/test-e2e \
-test.v \
-test.timeout=2h10m \
-test.run=${CI_TESTS_RUN} \
-test.parallel=20 \
--e2e.aws-credentials-file=/etc/hypershift-pool-aws-credentials/credentials \
Expand Down