-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Backport API changes to 4.9 #2493
Conversation
Adds a service account signing key to the HostedCluster spec. If specified, we skip reconciling discovery documents to an S3 bucket. This allows consumers of our API to generate their own signing key and place OIDC discovery documents wherever they like.
Currently the KubeAPIServerParams are constructed with the API Server address from the HCP status. This modifies reconciliation to use the InfraStatus to obtain the API Server address.
Currently, global configuration of HostedClusters needs to be specified as an arbitrary list of RawExtensions. This forces users to have to properly specify kind and apiVersion on basic configuration resources. In addition to that, redundant information needs to be provided as a list of secret and configmap references. This change simplifies hosted cluster configuration by including specific fields for each configuration resource's spec. The user has now explicit fields where they can specify configuration for their cluster.
This is done before anything else to prevent other update calls from failing if e.g. they are missing a new required field.
Enables support for IPv6 in HostedCluster API. Deprecates existing scalar values and replaces them with slices that mirror network settings in InstallConfig. Replaces individual fields for networking in the HostedControlPlane spec with the networking struct of the HostedCluster spec.
@a-dsouza: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/area hypershift-operator no RH coverage here. leaving lgtm to IBM after testing is satisfied. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-dsouza, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
@a-dsouza: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
What this PR does / why we need it: Backports the following PRs to enable v4.9 control planes to work with newer API fields:
This will enable 4.9 control planes to work without needing the conversion webhook.
Checklist