Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backport API changes to 4.9 #2493

Closed
wants to merge 13 commits into from

Conversation

a-dsouza
Copy link
Contributor

What this PR does / why we need it: Backports the following PRs to enable v4.9 control planes to work with newer API fields:

This will enable 4.9 control planes to work without needing the conversion webhook.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

csrwng and others added 11 commits April 20, 2023 14:10
Adds a service account signing key to the HostedCluster spec. If specified,
we skip reconciling discovery documents to an S3 bucket.

This allows consumers of our API to generate their own signing key and
place OIDC discovery documents wherever they like.
Currently the KubeAPIServerParams are constructed with the API Server
address from the HCP status. This modifies reconciliation to use the
InfraStatus to obtain the API Server address.
Currently, global configuration of HostedClusters needs to be specified
as an arbitrary list of RawExtensions. This forces users to have to
properly specify kind and apiVersion on basic configuration resources.
In addition to that, redundant information needs to be provided as a
list of secret and configmap references.

This change simplifies hosted cluster configuration by including
specific fields for each configuration resource's spec. The user has
now explicit fields where they can specify configuration for their
cluster.
This is done before anything else to prevent other update calls from failing if e.g. they are missing a new required field.
Enables support for IPv6 in HostedCluster API. Deprecates existing
scalar values and replaces them with slices that mirror network
settings in InstallConfig.

Replaces individual fields for networking in the HostedControlPlane spec
with the networking struct of the HostedCluster spec.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2023

@a-dsouza: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

feat: Backport API changes to 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-dsouza
Copy link
Contributor Author

/retest

@sjenning
Copy link
Contributor

sjenning commented May 1, 2023

/area hypershift-operator
/approve

no RH coverage here. leaving lgtm to IBM after testing is satisfied.

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels May 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-dsouza, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2023
@a-dsouza
Copy link
Contributor Author

a-dsouza commented May 1, 2023

/retest

1 similar comment
@a-dsouza
Copy link
Contributor Author

a-dsouza commented May 3, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

@a-dsouza: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2023
@a-dsouza a-dsouza closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants